Adopt more smart pointers in LocalFrame #27870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwlbuis
added
the
WebCore Misc.
|
EWS run on previous version of this PR (hash 20dd3ba) |
szewai
approved these changes
Apr 29, 2024
cdumez
requested changes
Apr 29, 2024
| @@ -134,23 +134,23 @@ DEFINE_DEBUG_ONLY_GLOBAL(WTF::RefCountedLeakCounter, frameCounter, ("Frame")); | |||
|
|
|||
| static inline float parentPageZoomFactor(LocalFrame* frame) | |||
| { | |||
| LocalFrame* parent = dynamicDowncast<LocalFrame>(frame->tree().parent()); | |||
| RefPtr parent = dynamicDowncast<LocalFrame>(frame->tree().parent()); | |||
| if (!parent) | |||
| return 1; | |||
| return parent->pageZoomFactor(); | |||
There was a problem hiding this comment.
This looks like a trivial inline function, no? So why are we doing smart pointer adoption here? Please follow the guidelines.
There was a problem hiding this comment.
Sorry, indeed I did not check for trivial inline functions. Fixed this one now and went over all other changes to check for this.
rwlbuis
force-pushed
the
eng/Adopt-more-smart-pointers-in-LocalFrame
branch
from
20dd3ba
to
15d06f8
Compare
|
EWS run on previous version of this PR (hash 15d06f8) |
🛠 🧪 jsc-arm64
szewai
approved these changes
Apr 30, 2024
Source/WebCore/page/LocalFrame.cpp
Outdated
|
|
||
| if (auto* window = JSDOMWindow::toWrapped(vm, value)) | ||
| if (RefPtr window = JSDOMWindow::toWrapped(vm, value)) |
There was a problem hiding this comment.
It seems the local variable vm is unnecessary
There was a problem hiding this comment.
Removed the local variable.
rwlbuis
force-pushed
the
eng/Adopt-more-smart-pointers-in-LocalFrame
branch
from
15d06f8
to
881201e
Compare
|
EWS run on current version of this PR (hash 881201e) |
https://bugs.webkit.org/show_bug.cgi?id=273397 Reviewed by Sihui Liu. Adopt more smart pointers in LocalFrame based on the [alpha.webkit.UncountedLocalVarsChecker] warning. * Source/WebCore/page/LocalFrame.cpp: (WebCore::parentPageZoomFactor): (WebCore::parentTextZoomFactor): (WebCore::rootFrame): (WebCore::LocalFrame::LocalFrame): (WebCore::LocalFrame::~LocalFrame): (WebCore::LocalFrame::shouldUsePrintingLayout const): (WebCore::LocalFrame::frameForWidget): (WebCore::LocalFrame::rangeForPoint): (WebCore::LocalFrame::debugDescription const): (WebCore::LocalFrame::contentFrameFromWindowOrFrameElement): Canonical link: https://commits.webkit.org/278206@main
webkit-commit-queue
force-pushed
the
eng/Adopt-more-smart-pointers-in-LocalFrame
branch
from
881201e
to
088a3e5
Compare
|
Committed 278206@main (088a3e5): https://commits.webkit.org/278206@main Reviewed commits have been landed. Closing PR #27870 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
088a3e5
881201e