Web Inspector: Top or bottom of Web Inspector is cut off on short viewports #27939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 349cc7a) |
|
Using steps to reproduce from https://bugs.webkit.org/show_bug.cgi?id=273506 Before
After
|
dcrousso
approved these changes
May 1, 2024
rcaliman-apple
force-pushed
the
eng/Web-Inspector-Top-or-bottom-of-Web-Inspector-is-cut-off-on-short-viewports
branch
from
349cc7a
to
774d9c3
Compare
|
EWS run on current version of this PR (hash 774d9c3) |
rcaliman-apple
added
the
merge-queue
webkit-commit-queue
force-pushed
the
eng/Web-Inspector-Top-or-bottom-of-Web-Inspector-is-cut-off-on-short-viewports
branch
from
774d9c3
to
56b5141
Compare
…wports https://bugs.webkit.org/show_bug.cgi?id=273506 rdar://117272735 Reviewed by Devin Rousso. The Console Drawer was allowed to be resized to an arbitrarily capped maximum height of `<div id="main">` that did not take into account the minimum height defined by the Tab Browser or the space taken up by the Quick Console. Their common container is an absolutely-positioned flex container that has its overflow hidden by `overflow: hidden` on the Web Inspector `<body>`. So when the Console Drawer was oversized, it pushed either the Quick Console or the top of the Tab bar beyond the visible viewport, depending on the successive layout operations (CSS and programmatic) that occur during Web Inspector launch. The patch sets a maximum height for the Console Drawer that is calculated explicitly. * Source/WebInspectorUI/UserInterface/Views/ConsoleDrawer.js: (WI.ConsoleDrawer.prototype._updateDrawerHeight): * Source/WebInspectorUI/UserInterface/Views/QuickConsole.js: * Source/WebInspectorUI/UserInterface/Views/Variables.css: (:root): Canonical link: https://commits.webkit.org/278208@main
webkit-commit-queue
force-pushed
the
eng/Web-Inspector-Top-or-bottom-of-Web-Inspector-is-cut-off-on-short-viewports
branch
from
56b5141
to
2a15afd
Compare
|
Committed 278208@main (2a15afd): https://commits.webkit.org/278208@main Reviewed commits have been landed. Closing PR #27939 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2a15afd
774d9c3
🧪 api-mac🧪 api-ios