Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PlayStation build of WebKitTestRunner after 278039@main #28061

Merged
merged 1 commit into from
May 3, 2024
Merged

Fix PlayStation build of WebKitTestRunner after 278039@main #28061

merged 1 commit into from
May 3, 2024

Conversation

donny-dont
Copy link
Contributor

@donny-dont donny-dont commented May 2, 2024 •
edited by webkit-early-warning-system
Loading

cf7a630

Fix PlayStation build of WebKitTestRunner after 278039@main
https://bugs.webkit.org/show_bug.cgi?id=273645

Unreviewed build fix.

Update method signatures.

* Tools/WebKitTestRunner/InjectedBundle/playstation/AccessibilityUIElementPlayStation.cpp:

Canonical link: https://commits.webkit.org/278299@main

fe5de00

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
loading 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@donny-dont donny-dont self-assigned this May 2, 2024
@donny-dont donny-dont added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label May 2, 2024
@donny-dont donny-dont marked this pull request as ready for review May 2, 2024 22:18
@donny-dont donny-dont force-pushed the eng/Fix-PlayStation-build-of-WebKitTestRunner-after-278039main branch from f55115b to 3a28bbb Compare May 2, 2024 22:30
@donny-dont donny-dont added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels May 2, 2024
@donny-dont donny-dont force-pushed the eng/Fix-PlayStation-build-of-WebKitTestRunner-after-278039main branch from 3a28bbb to fe5de00 Compare May 3, 2024 00:06
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented May 3, 2024 •
edited
Loading

EWS run on current version of this PR (hash fe5de00)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
loading 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented May 3, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 3a28bbb)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style loading 🛠 ios loading 🛠 mac loading 🛠 wpe loading 🛠 wincairo
✅ 🧪 bindings loading 🛠 ios-sim ✅ 🛠 mac-AS-debug loading 🧪 wpe-wk2
✅ 🧪 webkitperl loading 🧪 ios-wk2 loading 🧪 api-mac loading 🧪 api-wpe
⏳ 🧪 webkitpy loading 🧪 ios-wk2-wpt loading 🧪 mac-wk1 loading 🛠 wpe-skia
⏳ 🛠 🧪 jsc loading 🧪 api-ios loading 🧪 mac-wk2 ✅ 🛠 gtk
⏳ 🛠 🧪 jsc-arm64   🛠 tv ⏳ 🧪 mac-AS-debug-wk2 ⏳ 🧪 gtk-wk2
⏳ 🧪 services ⏳ 🛠 tv-sim loading 🧪 mac-wk2-stress ⏳ 🧪 api-gtk
  🛠 watch ⏳ 🛠 jsc-armv7
  🛠 🧪 unsafe-merge ⏳ 🛠 watch-sim ⏳ 🧪 jsc-armv7-tests

@donny-dont donny-dont added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 3, 2024
@donny-dont
Fix PlayStation build of WebKitTestRunner after 278039@main
cf7a630 
https://bugs.webkit.org/show_bug.cgi?id=273645

Unreviewed build fix.

Update method signatures.

* Tools/WebKitTestRunner/InjectedBundle/playstation/AccessibilityUIElementPlayStation.cpp:

Canonical link: https://commits.webkit.org/278299@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Fix-PlayStation-build-of-WebKitTestRunner-after-278039main branch from fe5de00 to cf7a630 Compare May 3, 2024 02:22
@webkit-commit-queue
Copy link
Collaborator

Committed 278299@main (cf7a630): https://commits.webkit.org/278299@main

Reviewed commits have been landed. Closing PR #28061 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit cf7a630 into WebKit:main May 3, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonWBedard JonWBedard Awaiting requested review from JonWBedard JonWBedard is a code owner

Assignees

@donny-dont donny-dont

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
3 participants
@donny-dont @webkit-early-warning-system @webkit-commit-queue