transform-style:preserve-3d doesn't work across display:contents ancestors #28077

mattwoodrow · 2024-05-03T01:55:01Z

`adf1f00`

transform-style:preserve-3d doesn't work across display:contents ancestors
https://bugs.webkit.org/show_bug.cgi?id=273627
<rdar://127468969>

Reviewed by Alan Baradlay.

When looking for the ancestor element to see if it has 'preserve-3d', any intermediate
ancestors with display:contents should be skipped.

* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/transform3d-preserve3d-014-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/transform3d-preserve3d-014.html: Added.
* LayoutTests/platform/mac/TestExpectations:
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::flattenedParent):
(WebCore::RenderLayer::ancestorLayerIsDOMParent const):

Canonical link: https://commits.webkit.org/278499@main

d8e6277

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
✅ 🧪 webkitpy	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-skia
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
✅ 🧪 services	✅ 🛠 tv-sim	~~🧪 mac-wk2-stress~~	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🛠 watch		✅ 🛠 jsc-armv7
	✅ 🛠 watch-sim		✅ 🧪 jsc-armv7-tests

webkit-early-warning-system · 2024-05-03T01:55:07Z

EWS run on previous version of this PR (hash adf1737)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	~~🧪 api-mac~~	✅ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	✅ 🛠 wpe-skia
	⏳ 🧪 api-ios	~~🧪 mac-wk2~~	✅ 🛠 gtk
	✅ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2	⏳ 🧪 gtk-wk2
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2-stress	⏳ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-05-03T02:45:04Z

EWS run on previous version of this PR (hash 0a7f113)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-05-06T01:47:29Z

EWS run on previous version of this PR (hash 81763e2)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
❌ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

alanbaradlay · 2024-05-07T02:40:22Z

Source/WebCore/rendering/RenderLayer.cpp

+    auto parent = flattenedParent(renderer().element());
+    if (parent && ancestor->renderer().element() == parent)


I guess flattenedParent(renderer().element()) == ancestor->renderer().element() would be sufficient but ofc checking against parent is less error prone.

(totally not suggesting to change it:)

I guess I was worried about nullptr == nullptr, not sure how probable that actually is.

yeah, probably close to 0, but then again being defensive here is not a bad thing.

webkit-early-warning-system · 2024-05-07T21:45:31Z

EWS run on current version of this PR (hash d8e6277)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
✅ 🧪 webkitpy	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-skia
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
✅ 🧪 services	✅ 🛠 tv-sim	~~🧪 mac-wk2-stress~~	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🛠 watch		✅ 🛠 jsc-armv7
	✅ 🛠 watch-sim		✅ 🧪 jsc-armv7-tests

…stors https://bugs.webkit.org/show_bug.cgi?id=273627 <rdar://127468969> Reviewed by Alan Baradlay. When looking for the ancestor element to see if it has 'preserve-3d', any intermediate ancestors with display:contents should be skipped. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/transform3d-preserve3d-014-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/transform3d-preserve3d-014.html: Added. * LayoutTests/platform/mac/TestExpectations: * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::flattenedParent): (WebCore::RenderLayer::ancestorLayerIsDOMParent const): Canonical link: https://commits.webkit.org/278499@main

webkit-commit-queue · 2024-05-08T09:19:50Z

Committed 278499@main (adf1f00): https://commits.webkit.org/278499@main

Reviewed commits have been landed. Closing PR #28077 and removing active labels.

mattwoodrow self-assigned this May 3, 2024

mattwoodrow added the Layout and Rendering For bugs with layout and rendering of Web pages. label May 3, 2024

mattwoodrow force-pushed the eng/preserve-3d-display-contents branch from adf1737 to 0a7f113 Compare May 3, 2024 02:44

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 3, 2024

mattwoodrow removed the merging-blocked Applied to prevent a change from being merged label May 6, 2024

mattwoodrow force-pushed the eng/preserve-3d-display-contents branch from 0a7f113 to 81763e2 Compare May 6, 2024 01:47

mattwoodrow requested a review from alanbaradlay May 7, 2024 02:24

alanbaradlay approved these changes May 7, 2024

View reviewed changes

mattwoodrow added merge-queue Applied to send a pull request to merge-queue and removed merge-queue Applied to send a pull request to merge-queue labels May 7, 2024

mattwoodrow force-pushed the eng/preserve-3d-display-contents branch from 81763e2 to d8e6277 Compare May 7, 2024 21:45

mattwoodrow added the merge-queue Applied to send a pull request to merge-queue label May 8, 2024

webkit-commit-queue force-pushed the eng/preserve-3d-display-contents branch from d8e6277 to adf1f00 Compare May 8, 2024 09:19

webkit-commit-queue merged commit adf1f00 into WebKit:main May 8, 2024

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

transform-style:preserve-3d doesn't work across display:contents ancestors #28077

transform-style:preserve-3d doesn't work across display:contents ancestors #28077

mattwoodrow commented May 3, 2024 •

edited by webkit-early-warning-system

Loading

webkit-early-warning-system commented May 3, 2024 •

edited

Loading

webkit-early-warning-system commented May 3, 2024 •

edited

Loading

webkit-early-warning-system commented May 6, 2024 •

edited

Loading

alanbaradlay May 7, 2024

alanbaradlay May 7, 2024

mattwoodrow May 7, 2024

alanbaradlay May 7, 2024

webkit-early-warning-system commented May 7, 2024 •

edited

Loading

webkit-commit-queue commented May 8, 2024

		auto parent = flattenedParent(renderer().element());
		if (parent && ancestor->renderer().element() == parent)

transform-style:preserve-3d doesn't work across display:contents ancestors #28077

transform-style:preserve-3d doesn't work across display:contents ancestors #28077

Conversation

mattwoodrow commented May 3, 2024 • edited by webkit-early-warning-system Loading

adf1f00

webkit-early-warning-system commented May 3, 2024 • edited Loading

webkit-early-warning-system commented May 3, 2024 • edited Loading

webkit-early-warning-system commented May 6, 2024 • edited Loading

alanbaradlay May 7, 2024

Choose a reason for hiding this comment

alanbaradlay May 7, 2024

Choose a reason for hiding this comment

mattwoodrow May 7, 2024

Choose a reason for hiding this comment

alanbaradlay May 7, 2024

Choose a reason for hiding this comment

webkit-early-warning-system commented May 7, 2024 • edited Loading

webkit-commit-queue commented May 8, 2024

mattwoodrow commented May 3, 2024 •

edited by webkit-early-warning-system

Loading

`adf1f00`

webkit-early-warning-system commented May 3, 2024 •

edited

Loading

webkit-early-warning-system commented May 3, 2024 •

edited

Loading

webkit-early-warning-system commented May 6, 2024 •

edited

Loading

webkit-early-warning-system commented May 7, 2024 •

edited

Loading