[WPE] COG configuration files are not regenerated when certain params are changed

[pgorszkowski-igalia]

cb597b1

[WPE] COG configuration files are not regenerated when certain params are changed
https://bugs.webkit.org/show_bug.cgi?id=273673

Reviewed by Adrian Perez de Castro.

It fixes problem with regeneration and rebuilding the COG when certain parameters are changed
(e.g.: ENABLE_WPE_1_1_API (ON/OFF))

* Tools/PlatformWPE.cmake:

Canonical link: https://commits.webkit.org/278398@main

360d395

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on current version of this PR (hash 360d395)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

[pgorszkowski-igalia]

It does not cause rebuilding of the whole COG each time, only if any of the input parameters have changed.

[dpino]

This patch also fixes Cog compilation after running:

Tools/Script/clean-webkit --derived-sources-only

The option --derived-sources-only deletes all DerivedSources and ninja files in WebKitBuild, including WebKitBuild/WPE/Release/Tools/cog-prefix/src/cog-build/build.ninja. Since this file is not regenerated, currently Cog compilation fails after running the code above.

The EWS GTK and WPE build bots are now executing an additional step, clean-derived-sources, before the compile-webkit step:

https://ews-build.webkit.org/#/builders/5/builds/53417

In the case of WPE, we were forced to switch the EWS WPE Build workers to MiniBrowser because WebKitBuild/WPE/Release/Tools/cog-prefix/src/cog-build/build.ninja is not regenerated if it was removed.

[dpino]

LGTM, although I'm not a reviewer.

I think the most suitable person to review this patch is @aperezdc.

[aperezdc]

I was under the impression that --reconfigure would always cause a rebuild, but I'm happy it doesn't (to do that one would need both --reconfigure --wipe).

LGTM!

[webkit-commit-queue]

Committed 278398@main (cb597b1): https://commits.webkit.org/278398@main

Reviewed commits have been landed. Closing PR #28085 and removing active labels.