-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WebGPU] UAF in GPUBuffer::getMappedRange #28098
[WebGPU] UAF in GPUBuffer::getMappedRange #28098
Conversation
EWS run on previous version of this PR (hash e6ac5b1) |
e6ac5b1
to
b1de078
Compare
EWS run on previous version of this PR (hash b1de078) |
b1de078
to
27890cb
Compare
EWS run on previous version of this PR (hash 27890cb) |
27890cb
to
8628056
Compare
EWS run on previous version of this PR (hash 8628056) |
8628056
to
1b482d5
Compare
EWS run on current version of this PR (hash 1b482d5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Safe-Merge-Queue: Build #19958. |
https://bugs.webkit.org/show_bug.cgi?id=273685 <radar://127490690> Reviewed by Dan Glastonbury. Fix UAF by using a callback and update test expectations to run in Debug which would have likely caught this issue. * LayoutTests/platform/mac-wk2/TestExpectations: * Source/WebCore/Modules/WebGPU/GPUBuffer.cpp: (WebCore::GPUBuffer::getMappedRange): * Source/WebCore/Modules/WebGPU/Implementation/WebGPUBufferImpl.cpp: (WebCore::WebGPU::BufferImpl::getMappedRange): * Source/WebCore/Modules/WebGPU/Implementation/WebGPUBufferImpl.h: * Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUBuffer.h: * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.cpp: (WebKit::WebGPU::RemoteBufferProxy::getMappedRange): * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.h: Canonical link: https://commits.webkit.org/278392@main
1b482d5
to
cf23d24
Compare
Committed 278392@main (cf23d24): https://commits.webkit.org/278392@main Reviewed commits have been landed. Closing PR #28098 and removing active labels. |
cf23d24
1b482d5