[Unified Text Replacement] When a "rich text" text replacement session ends, the session should be undone if it is not accepted #28122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rr-codes
added
the
HTML Editing
|
EWS run on current version of this PR (hash bd072ec)
|
aprotyas
approved these changes
May 3, 2024
rr-codes
added
the
unsafe-merge-queue
…n ends, the session should be undone if it is not accepted https://bugs.webkit.org/show_bug.cgi?id=273709 rdar://127390343 Reviewed by Abrar Rahman Protyasha. Ensure that `didEndTextReplacementSession` handles both plain text and rich text replacements properly. * Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm: (WebKit::UnifiedTextReplacementController::didEndTextReplacementSession<WebUnifiedTextReplacementType::PlainText>): (WebKit::UnifiedTextReplacementController::didEndTextReplacementSession<WebUnifiedTextReplacementType::RichText>): (WebKit::UnifiedTextReplacementController::didEndTextReplacementSession): * Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.h: Canonical link: https://commits.webkit.org/278345@main
webkit-commit-queue
force-pushed
the
eng/127390343
branch
from
bd072ec
to
c53d438
Compare
megangardner
approved these changes
May 3, 2024
| if (accepted) | ||
| return; | ||
|
|
||
| RefPtr document = this->document(); |
There was a problem hiding this comment.
Check that you have a document, like you do below.
|
Committed 278345@main (c53d438): https://commits.webkit.org/278345@main Reviewed commits have been landed. Closing PR #28122 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c53d438
bd072ec
🛠 wpe🛠 wincairo🧪 wpe-wk2🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 api-ios🧪 mac-wk2🛠 tv🧪 mac-AS-debug-wk2🧪 gtk-wk2🛠 tv-sim🧪 mac-wk2-stress🧪 api-gtk🛠 watch🛠 watch-sim