[GTK] Extraneous empty bar shown in detached inspector windows

[aperezdc]

0995cf2

[GTK] Extraneous empty bar shown in detached inspector windows
https://bugs.webkit.org/show_bug.cgi?id=255585

Reviewed by Carlos Garcia Campos.

The WI.undockedTitleAreaHeight() function only returns non-zero values
for Mac, but in Variables.css the --undocked-title-area-height variable
is set always to a non-zero value, the exact value depending on the
MacOS version. Add an :is(.mac-platform) match to leave the value
unchanged from zero in any non-Mac platform to keep the value in sync
with what WI.undockedTitleAreaHeight() returns.

* Source/WebInspectorUI/UserInterface/Views/Variables.css: Only change
  the --undocked-title-area-height variable for Mac.

Canonical link: https://commits.webkit.org/278418@main

621f212

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on current version of this PR (hash 621f212)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-skia
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim

[webkit-commit-queue]

Committed 278418@main (0995cf2): https://commits.webkit.org/278418@main

Reviewed commits have been landed. Closing PR #28170 and removing active labels.

[aperezdc]

Backported into the 2.44 branch as commit 049054f

[dcrousso]

i feel like this would be better written as

&:is(.mac-platform):not(.monterey, .big-sur):not(.docked) {

or even more ideally as

&:is(.mac-platform.catalina):not(.docked) {

since i dont think we support anything before macOS 10.15 Catalina

[aperezdc]

@dcrousso I'll send a follow-up, for this I tried to apply only the smallest change that would avoid applying the non-zero size to non-Mac platforms.

[aperezdc]

@dcrousso I'll send a follow-up, for this I tried to apply only the smallest change that would avoid applying the non-zero size to non-Mac platforms.

Done, PR at #28287

I saw still references to Mojave in the code, so I kept it in the selector.