[JSC] Use std::span::data in super hot function #28262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constellation
added
the
JavaScriptCore
|
EWS run on current version of this PR (hash 7767ef8) |
Constellation
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=273852 rdar://127703218 Reviewed by Keith Miller. With 277836@main and 278441@main, we observed large regression in JetStream2/cdjs. This patch attempts to recover that regression. * Source/JavaScriptCore/runtime/IntlObjectInlines.h: (JSC::compareASCIIWithUCADUCETLevel3): (JSC::compareASCIIWithUCADUCET): Canonical link: https://commits.webkit.org/278486@main
webkit-commit-queue
force-pushed
the
eng/JSC-Use-stdspandata-in-super-hot-function
branch
from
7767ef8
to
ed761c3
Compare
|
Committed 278486@main (ed761c3): https://commits.webkit.org/278486@main Reviewed commits have been landed. Closing PR #28262 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ed761c3
7767ef8
🧪 wpe-wk2🧪 ios-wk2-wpt🛠 🧪 jsc🧪 api-ios🧪 gtk-wk2🛠 tv-sim🧪 mac-wk2-stress🛠 watch-sim