REGRESSION(266644@main):[ macOS WK1 ] report-original-url-on-mixed-content-frame.https.sub.html is a constant text failure #28315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentfulgham
added
New Bugs
|
EWS run on current version of this PR (hash 6572a59) |
nt1m
approved these changes
May 9, 2024
Ahmad-S792
added
merge-queue
…ntent-frame.https.sub.html is a constant text failure https://bugs.webkit.org/show_bug.cgi?id=266047 <rdar://problem/119349300> Reviewed by Tim Nguyen. The original result for LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-original-url-on-mixed-content-frame.https.sub-expected.txt was failure on all platforms. Ryan's work in 266644@main progressed this test case in modern WebKit, and he checked that expectation in. Unfortunately, WebKitLegacy relies on a PingHandle implementation that cannot authenticate against https (which is a missing feature in the entire deprecated WebKitLegacy platform for the old PingHandle implementation). We do to intend to invest time working on implementing such a feature in WebKitLegacy, so we expect this test to fail. This patch lands a new WebKitLegacy test expectation to document the expected behavior. Note that the console output on WebKitLegacy shows that the load was blocked properly in WebKitLegacy. It is only the Reporting API message that fails in this test, simply because WebKitLegacy cannot handle the mixture of an insecure main page sending reports to an secure reporting target. * LayoutTests/platform/mac-wk1/TestExpectations: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/content-security-policy/reporting/report-original-url-on-mixed-content-frame.https.sub-expected.txt: Added. Canonical link: https://commits.webkit.org/278543@main
webkit-commit-queue
force-pushed
the
eng/266047
branch
from
6572a59
to
c741b1a
Compare
|
Committed 278543@main (c741b1a): https://commits.webkit.org/278543@main Reviewed commits have been landed. Closing PR #28315 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c741b1a
6572a59
🧪 wpe-wk2🧪 ios-wk2-wpt🧪 mac-AS-debug-wk2🧪 gtk-wk2🧪 api-gtk