Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Element::hasAttribute fast path #28321

Merged
merged 1 commit into from
May 9, 2024
Merged

Add Element::hasAttribute fast path #28321

merged 1 commit into from
May 9, 2024

Conversation

Constellation
Copy link
Member

@Constellation Constellation commented May 9, 2024 •
edited by webkit-early-warning-system
Loading

0d5648d

Add Element::hasAttribute fast path
https://bugs.webkit.org/show_bug.cgi?id=273922
rdar://problem/127788707

Reviewed by Chris Dumez.

Let's cherry-pick [1]. We should avoid creating QualifiedName again in hasAttributeNS.

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/5490227

* Source/WebCore/dom/Element.cpp:
(WebCore::Element::hasAttribute const):

Canonical link: https://commits.webkit.org/278571@main

d71c736

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@Constellation Constellation self-assigned this May 9, 2024
@Constellation Constellation added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label May 9, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented May 9, 2024 •
edited
Loading

EWS run on current version of this PR (hash d71c736)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 9, 2024
@Constellation
Add Element::hasAttribute fast path
0d5648d 
https://bugs.webkit.org/show_bug.cgi?id=273922
rdar://problem/127788707

Reviewed by Chris Dumez.

Let's cherry-pick [1]. We should avoid creating QualifiedName again in hasAttributeNS.

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/5490227

* Source/WebCore/dom/Element.cpp:
(WebCore::Element::hasAttribute const):

Canonical link: https://commits.webkit.org/278571@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Add-ElementhasAttribute-fast-path branch from d71c736 to 0d5648d Compare May 9, 2024 17:17
@webkit-commit-queue
Copy link
Collaborator

Committed 278571@main (0d5648d): https://commits.webkit.org/278571@main

Reviewed commits have been landed. Closing PR #28321 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 0d5648d into WebKit:main May 9, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez cdumez approved these changes

@rniwa rniwa Awaiting requested review from rniwa rniwa is a code owner

Assignees

@Constellation Constellation

Labels
DOM For bugs specific to XML/HTML DOM elements (including parsing).
Projects
None yet
Milestone
No milestone
4 participants
@Constellation @webkit-early-warning-system @webkit-commit-queue @cdumez