Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cocoa] Allow decoding the animated AVIF image whose image type is "public.avis" #2836

Merged
merged 1 commit into from
Aug 1, 2022
Merged

[Cocoa] Allow decoding the animated AVIF image whose image type is "public.avis" #2836

merged 1 commit into from
Aug 1, 2022

Conversation

shallawa
Copy link
Contributor

@shallawa shallawa commented Jul 29, 2022 •
edited by webkit-commit-queue

7cb2a04

[Cocoa] Allow decoding the animated AVIF image whose image type is "public.avis"
https://bugs.webkit.org/show_bug.cgi?id=243330
rdar://97757110

Reviewed by Simon Fraser.

The image type of the static AVIF image which is "public.avif" was added to the
list of supported image formats in bug 241904. We need also to add the image type
of the animated AVIF image which is "public.avis".

* Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:
(WebCore::animationPropertiesFromProperties):
(WebCore::ImageDecoderCG::frameDurationAtIndex const):
(WebCore::animationHEICSPropertiesFromProperties): Deleted.
* Source/WebCore/platform/graphics/cg/UTIRegistry.cpp:
(WebCore::defaultSupportedImageTypes):

Canonical link: https://commits.webkit.org/253002@main

@shallawa shallawa self-assigned this Jul 29, 2022
@shallawa shallawa added Images For bugs in image handling. WebKit Nightly Build labels Jul 29, 2022
@shallawa shallawa requested a review from smfr July 29, 2022 02:07
@shallawa shallawa added the merge-queue Applied to send a pull request to merge-queue label Aug 1, 2022
@shallawa
[Cocoa] Allow decoding the animated AVIF image whose image type is "p…
7cb2a04 
…ublic.avis"

https://bugs.webkit.org/show_bug.cgi?id=243330
rdar://97757110

Reviewed by Simon Fraser.

The image type of the static AVIF image which is "public.avif" was added to the
list of supported image formats in bug 241904. We need also to add the image type
of the animated AVIF image which is "public.avis".

* Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:
(WebCore::animationPropertiesFromProperties):
(WebCore::ImageDecoderCG::frameDurationAtIndex const):
(WebCore::animationHEICSPropertiesFromProperties): Deleted.
* Source/WebCore/platform/graphics/cg/UTIRegistry.cpp:
(WebCore::defaultSupportedImageTypes):

Canonical link: https://commits.webkit.org/253002@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Cocoa-Allow-decoding-the-animated-AVIF-image-whose-image-type-is-public-avis branch from f258fcc to 7cb2a04 Compare August 1, 2022 18:48
@webkit-commit-queue
Copy link
Collaborator

Committed 253002@main (7cb2a04): https://commits.webkit.org/253002@main

Reviewed commits have been landed. Closing PR #2836 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 7cb2a04 into WebKit:main Aug 1, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smfr smfr smfr approved these changes

Assignees

@shallawa shallawa

Labels
Images For bugs in image handling.
Projects
None yet
Milestone
No milestone
4 participants
@shallawa @webkit-commit-queue @smfr @webkit-early-warning-system