Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GTK] [2.45.1] Fails to build on big-endian machines due to lack of support in Skia #28429

Merged
merged 1 commit into from
May 14, 2024
Merged

[GTK] [2.45.1] Fails to build on big-endian machines due to lack of support in Skia #28429

merged 1 commit into from
May 14, 2024

Conversation

mcatanzaro
Copy link
Contributor

@mcatanzaro mcatanzaro commented May 11, 2024 •
edited by webkit-early-warning-system
Loading

7a1468c

[GTK] [2.45.1] Fails to build on big-endian machines due to lack of support in Skia
https://bugs.webkit.org/show_bug.cgi?id=274032

Reviewed by Carlos Garcia Campos.

Don't use skia on big endian architectures.

* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:

Canonical link: https://commits.webkit.org/278740@main

6b3584c

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ⏳ 🛠 wpe-skia
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch   🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim   🧪 jsc-armv7-tests

@mcatanzaro mcatanzaro requested a review from a team as a code owner May 11, 2024 12:10
@mcatanzaro mcatanzaro self-assigned this May 11, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented May 11, 2024 •
edited
Loading

EWS run on previous version of this PR (hash a764879)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ⏳ 🛠 wpe-skia
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch   🛠 jsc-armv7
✅ 🛠 watch-sim   🧪 jsc-armv7-tests

@mcatanzaro mcatanzaro added the WebKitGTK Bugs related to the Gtk API layer. label May 11, 2024
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 11, 2024
@mcatanzaro
Copy link
Contributor Author

I assume the wpe-wk2 EWS doesn't have CMake 3.20 available....

@bertogg
Copy link
Contributor

bertogg commented May 12, 2024

Tested with WebKitGTK 2.45.1 on s390x, I confirm that it works fine.

@mcatanzaro mcatanzaro removed the merging-blocked Applied to prevent a change from being merged label May 13, 2024
@mcatanzaro mcatanzaro force-pushed the eng/GTK-2-45-1-Fails-to-build-on-big-endian-machines-due-to-lack-of-support-in-Skia branch from a764879 to 60b7437 Compare May 13, 2024 17:25
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented May 13, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 60b7437)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
⏳ 🧪 ios-wk2-wpt ⏳ 🛠 wpe-skia
  🛠 🧪 jsc ⏳ 🧪 api-ios   🧪 mac-wk2   🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🛠 tv-sim   🧪 mac-wk2-stress   🧪 api-gtk
  🛠 watch   🛠 jsc-armv7
  🛠 watch-sim   🧪 jsc-armv7-tests

@mcatanzaro
Copy link
Contributor Author

I assume the wpe-wk2 EWS doesn't have CMake 3.20 available....

It was a typo, but let's default to enabling skia for older CMake versions anyway.

@mcatanzaro mcatanzaro force-pushed the eng/GTK-2-45-1-Fails-to-build-on-big-endian-machines-due-to-lack-of-support-in-Skia branch from 60b7437 to 6b3584c Compare May 13, 2024 17:27
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented May 13, 2024 •
edited
Loading

EWS run on current version of this PR (hash 6b3584c)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ⏳ 🛠 wpe-skia
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch   🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim   🧪 jsc-armv7-tests

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 13, 2024
@carlosgcampos carlosgcampos added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels May 14, 2024
@mcatanzaro @carlosgcampos
[GTK] [2.45.1] Fails to build on big-endian machines due to lack of s…
7a1468c 
…upport in Skia

https://bugs.webkit.org/show_bug.cgi?id=274032

Reviewed by Carlos Garcia Campos.

Don't use skia on big endian architectures.

* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:

Canonical link: https://commits.webkit.org/278740@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/GTK-2-45-1-Fails-to-build-on-big-endian-machines-due-to-lack-of-support-in-Skia branch from 6b3584c to 7a1468c Compare May 14, 2024 07:36
@webkit-commit-queue
Copy link
Collaborator

Committed 278740@main (7a1468c): https://commits.webkit.org/278740@main

Reviewed commits have been landed. Closing PR #28429 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 7a1468c into WebKit:main May 14, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosgcampos carlosgcampos carlosgcampos approved these changes

Assignees

@mcatanzaro mcatanzaro

Labels
WebKitGTK Bugs related to the Gtk API layer.
Projects
None yet
Milestone
No milestone
6 participants
@mcatanzaro @webkit-early-warning-system @bertogg @webkit-commit-queue @carlosgcampos @webkit-ews-buildbot