Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable dlsym callbacks #28432

Merged
merged 1 commit into from
May 13, 2024
Merged

Disable dlsym callbacks #28432

merged 1 commit into from
May 13, 2024

Conversation

pvollan
Copy link
Contributor

@pvollan pvollan commented May 11, 2024 •
edited by webkit-early-warning-system
Loading

ebe6945

Disable dlsym callbacks
https://bugs.webkit.org/show_bug.cgi?id=274040
rdar://127940574

Reviewed by Chris Dumez.

Disable dlsym callbacks on macOS since this is no longer needed. This should also be a
small performance improvement.

* Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:
(WebKit::AuxiliaryProcess::initializeSandbox):

Canonical link: https://commits.webkit.org/278700@main

9c18944

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ⏳ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@pvollan pvollan self-assigned this May 11, 2024
@pvollan pvollan added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label May 11, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented May 11, 2024 •
edited
Loading

EWS run on current version of this PR (hash 9c18944)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ⏳ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@pvollan pvollan requested review from bnham, cdumez and szewai May 11, 2024 21:39
@pvollan
Copy link
Contributor Author

pvollan commented May 13, 2024

Thanks for reviewing!

@pvollan pvollan added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 13, 2024
@pvollan
Disable dlsym callbacks
ebe6945 
https://bugs.webkit.org/show_bug.cgi?id=274040
rdar://127940574

Reviewed by Chris Dumez.

Disable dlsym callbacks on macOS since this is no longer needed. This should also be a
small performance improvement.

* Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:
(WebKit::AuxiliaryProcess::initializeSandbox):

Canonical link: https://commits.webkit.org/278700@main
@webkit-commit-queue
Copy link
Collaborator

Committed 278700@main (ebe6945): https://commits.webkit.org/278700@main

Reviewed commits have been landed. Closing PR #28432 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit ebe6945 into WebKit:main May 13, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez cdumez approved these changes

@bnham bnham Awaiting requested review from bnham

@szewai szewai Awaiting requested review from szewai

Assignees

@pvollan pvollan

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
4 participants
@pvollan @webkit-early-warning-system @webkit-commit-queue @cdumez