Regression(278398@main): COG does not build for the first time with meson before 1.1.0 #28470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgorszkowski-igalia
requested review from
zdobersek,
a team and
JonWBedard
as code owners
pgorszkowski-igalia
added
the
New Bugs
|
EWS run on previous version of this PR (hash 23fed7c) |
dpino
approved these changes
May 13, 2024
Tools/wpe/meson-wrapper
Outdated
| @@ -0,0 +1,14 @@ | |||
| #! /bin/sh | |||
There was a problem hiding this comment.
Better to use /usr/bin/env sh since not all Linux distros have sh located at /bin/sh (i.e: NixOS).
| reconfigure_mode=$1 | ||
| shift | ||
|
|
||
| if [ "$reconfigure_mode" = flag ] || [ -r "$1/build.ninja" ] ; then |
There was a problem hiding this comment.
I think in this statement variable $1 can be replaced for $reconfigure_mode.
There was a problem hiding this comment.
reconfigure_mode holds what was in $1, after 'shift' $1 has actually the second parameter which was passed to meson-wrapper (<BINARY_DIR>)
Tools/wpe/meson-wrapper
Outdated
| shift | ||
|
|
||
| if [ "$reconfigure_mode" = flag ] || [ -r "$1/build.ninja" ] ; then | ||
| set -- setup --reconfigure "$@" |
There was a problem hiding this comment.
I think there's a tab here. I think all other bash scripts use 4-space indentation.
Tools/wpe/meson-wrapper
Outdated
| if [ "$reconfigure_mode" = flag ] || [ -r "$1/build.ninja" ] ; then | ||
| set -- setup --reconfigure "$@" | ||
| else | ||
| set -- setup "$@" |
pgorszkowski-igalia
force-pushed
the
eng/Regression278398main-COG-does-not-build-for-the-first-time-with-meson-before-1-1-0
branch
from
23fed7c
to
0b43cc1
Compare
|
EWS run on current version of this PR (hash 0b43cc1) |
webkit-ews-buildbot
added
the
merging-blocked
aperezdc
approved these changes
May 14, 2024
pgorszkowski-igalia
added
merge-queue
…eson before 1.1.0 https://bugs.webkit.org/show_bug.cgi?id=273871 Reviewed by Adrian Perez de Castro. With this change "--reconfigure" option is added to meson(COG) only if meson version is greater than 1.1.0 or if build.ninja exists (which means that COG was previously configured). * Tools/PlatformWPE.cmake: * Tools/wpe/meson-wrapper: Added. Canonical link: https://commits.webkit.org/278747@main
webkit-commit-queue
force-pushed
the
eng/Regression278398main-COG-does-not-build-for-the-first-time-with-meson-before-1-1-0
branch
from
0b43cc1
to
b653500
Compare
|
Committed 278747@main (b653500): https://commits.webkit.org/278747@main Reviewed commits have been landed. Closing PR #28470 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b653500
0b43cc1