Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPE] WPE Platform: add wpe_keymap_translate_keyboard_state() #28524

Conversation

carlosgcampos
Copy link
Contributor

@carlosgcampos carlosgcampos commented May 14, 2024

f873c16

[WPE] WPE Platform: add wpe_keymap_translate_keyboard_state()
https://bugs.webkit.org/show_bug.cgi?id=274143

Reviewed by Alejandro G. Castro.

This will be needed by automation.

* Source/WebKit/WPEPlatform/wpe/WPEKeymap.cpp:
(wpe_keymap_translate_keyboard_state):
* Source/WebKit/WPEPlatform/wpe/WPEKeymap.h:
* Source/WebKit/WPEPlatform/wpe/WPEKeymapXKB.cpp:
(xkbModifiersFromWPEModifiers):
(wpeModifiersFromXKBModifiers):
(wpeKeymapXKBTranslateKeyboardState):
(wpeKeymapXKBGetModifiers):
(wpe_keymap_xkb_class_init):

Canonical link: https://commits.webkit.org/278854@main

e912578

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug ❌ πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac ❌ πŸ§ͺ api-wpe
βœ… πŸ§ͺ ios-wk2-wpt ⏳ πŸ›  wpe-skia
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ›  gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 ❌ πŸ§ͺ gtk-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2-stress βœ… πŸ§ͺ api-gtk
βœ… πŸ›  watch
βœ… πŸ›  πŸ§ͺ unsafe-merge βœ… πŸ›  watch-sim

@carlosgcampos carlosgcampos requested review from zdobersek and a team as code owners May 14, 2024 10:39
@carlosgcampos carlosgcampos self-assigned this May 14, 2024
Copy link
Contributor

@alexgcastro alexgcastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlosgcampos carlosgcampos added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 16, 2024
https://bugs.webkit.org/show_bug.cgi?id=274143

Reviewed by Alejandro G. Castro.

This will be needed by automation.

* Source/WebKit/WPEPlatform/wpe/WPEKeymap.cpp:
(wpe_keymap_translate_keyboard_state):
* Source/WebKit/WPEPlatform/wpe/WPEKeymap.h:
* Source/WebKit/WPEPlatform/wpe/WPEKeymapXKB.cpp:
(xkbModifiersFromWPEModifiers):
(wpeModifiersFromXKBModifiers):
(wpeKeymapXKBTranslateKeyboardState):
(wpeKeymapXKBGetModifiers):
(wpe_keymap_xkb_class_init):

Canonical link: https://commits.webkit.org/278854@main
@webkit-commit-queue webkit-commit-queue force-pushed the wpe-platform-translate-keyboard-state branch from e912578 to f873c16 Compare May 16, 2024 08:16
@webkit-commit-queue
Copy link
Collaborator

Committed 278854@main (f873c16): https://commits.webkit.org/278854@main

Reviewed commits have been landed. Closing PR #28524 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit f873c16 into WebKit:main May 16, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 16, 2024
@carlosgcampos carlosgcampos deleted the wpe-platform-translate-keyboard-state branch May 16, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WPE WebKit WebKit WPE component
Projects
None yet
4 participants