Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WGSL] Constant size for array types should be concretized #28531

Conversation

tadeuzagallo
Copy link
Member

@tadeuzagallo tadeuzagallo commented May 14, 2024

@tadeuzagallo tadeuzagallo self-assigned this May 14, 2024
@tadeuzagallo tadeuzagallo added the WebGPU For bugs in WebGPU label May 14, 2024
@tadeuzagallo tadeuzagallo added the merge-queue Applied to send a pull request to merge-queue label May 14, 2024
https://bugs.webkit.org/show_bug.cgi?id=274149
rdar://127986684

Reviewed by Mike Wyrzykowski.

The size of an array type has to be a concrete integer, but we were using the
constant value without concretizing, so 64-bit integers were allowed.

* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
* Source/WebGPU/WGSL/tests/invalid/array.wgsl:

Canonical link: https://commits.webkit.org/278761@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WGSL-Constant-size-for-array-types-should-be-concretized branch from 86eab11 to 6dae8e2 Compare May 14, 2024 15:45
@webkit-commit-queue
Copy link
Collaborator

Committed 278761@main (6dae8e2): https://commits.webkit.org/278761@main

Reviewed commits have been landed. Closing PR #28531 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 6dae8e2 into WebKit:main May 14, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebGPU For bugs in WebGPU
Projects
None yet
4 participants