Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing exception check in JSGenericTypedArrayViewPrototypeFunctions.h's speciesConstruct(). #2854

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Fix missing exception check in JSGenericTypedArrayViewPrototypeFunctions.h's speciesConstruct(). #2854

merged 1 commit into from
Jul 29, 2022

Conversation

MenloDorian
Copy link

@MenloDorian MenloDorian commented Jul 29, 2022 •
edited by webkit-commit-queue

6a77746

Fix missing exception check in JSGenericTypedArrayViewPrototypeFunctions.h's speciesConstruct().
https://bugs.webkit.org/show_bug.cgi?id=243348

Reviewed by Yusuke Suzuki.

This issue was showing up as unchecked exception errors when doing Debug build JSC stress test runs.

* Source/JavaScriptCore/runtime/JSGenericTypedArrayViewPrototypeFunctions.h:
(JSC::speciesConstruct):

Canonical link: https://commits.webkit.org/252954@main

@MenloDorian MenloDorian requested a review from a team as a code owner July 29, 2022 17:36
@MenloDorian MenloDorian self-assigned this Jul 29, 2022
@MenloDorian MenloDorian added JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. WebKit Nightly Build labels Jul 29, 2022
Constellation
Constellation approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@MenloDorian MenloDorian added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jul 29, 2022
Fix missing exception check in JSGenericTypedArrayViewPrototypeFuncti…
6a77746 
…ons.h's speciesConstruct().

https://bugs.webkit.org/show_bug.cgi?id=243348

Reviewed by Yusuke Suzuki.

This issue was showing up as unchecked exception errors when doing Debug build JSC stress test runs.

* Source/JavaScriptCore/runtime/JSGenericTypedArrayViewPrototypeFunctions.h:
(JSC::speciesConstruct):

Canonical link: https://commits.webkit.org/252954@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Fix-missing-exception-check-in-JSGenericTypedArrayViewPrototypeFunctions-hs-speciesConstruct- branch from b3353bb to 6a77746 Compare July 29, 2022 17:43
@webkit-early-warning-system webkit-early-warning-system merged commit 6a77746 into WebKit:main Jul 29, 2022
@webkit-commit-queue
Copy link
Collaborator

Committed 252954@main (6a77746): https://commits.webkit.org/252954@main

Reviewed commits have been landed. Closing PR #2854 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jul 29, 2022
@MenloDorian MenloDorian deleted the eng/Fix-missing-exception-check-in-JSGenericTypedArrayViewPrototypeFunctions-hs-speciesConstruct- branch August 1, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Constellation Constellation Constellation approved these changes

Assignees

@MenloDorian MenloDorian

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
4 participants
@MenloDorian @webkit-commit-queue @Constellation @webkit-early-warning-system