Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TextStream dumping for WebKit::RepaintRequirements #28579

Merged
merged 1 commit into from
May 15, 2024
Merged

Add TextStream dumping for WebKit::RepaintRequirements #28579

merged 1 commit into from
May 15, 2024

Conversation

aprotyas
Copy link
Member

@aprotyas aprotyas commented May 15, 2024 •
edited by webkit-early-warning-system

f54cee4

Add TextStream dumping for WebKit::RepaintRequirements
https://bugs.webkit.org/show_bug.cgi?id=274189
rdar://128097770

Reviewed by Simon Fraser and Sammy Gill.

This patch typedefs OptionSet<RepaintRequirement> to RepaintRequirements
for easier reference, and adds a TextStream operator<< overload for said
type to aid with debugging.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::updateTrackedAnnotation):
(WebKit::UnifiedPDFPlugin::handlePDFActionForAnnotation):
(WebKit::AnnotationTrackingState::startAnnotationTracking):
(WebKit::UnifiedPDFPlugin::setDisplayModeAndUpdateLayout):
(WebKit::operator<<):

Canonical link: https://commits.webkit.org/278798@main

0fbde6b

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ⏳ 🛠 wpe-skia
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@aprotyas aprotyas requested a review from cdumez as a code owner May 15, 2024 00:46
@aprotyas aprotyas self-assigned this May 15, 2024
@aprotyas aprotyas added the PDF For bugs in WebKit's built-in PDF support. label May 15, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 6af1f50)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ⏳ 🛠 wpe-skia
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 15, 2024
@aprotyas aprotyas removed the merging-blocked Applied to prevent a change from being merged label May 15, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 0fbde6b)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ⏳ 🛠 wpe-skia
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@aprotyas
Copy link
Member Author

aprotyas commented May 15, 2024 •
edited

Thanks for the reviews!

@aprotyas aprotyas added the merge-queue Applied to send a pull request to merge-queue label May 15, 2024
@aprotyas
Add TextStream dumping for WebKit::RepaintRequirements
f54cee4 
https://bugs.webkit.org/show_bug.cgi?id=274189
rdar://128097770

Reviewed by Simon Fraser and Sammy Gill.

This patch typedefs OptionSet<RepaintRequirement> to RepaintRequirements
for easier reference, and adds a TextStream operator<< overload for said
type to aid with debugging.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::updateTrackedAnnotation):
(WebKit::UnifiedPDFPlugin::handlePDFActionForAnnotation):
(WebKit::AnnotationTrackingState::startAnnotationTracking):
(WebKit::UnifiedPDFPlugin::setDisplayModeAndUpdateLayout):
(WebKit::operator<<):

Canonical link: https://commits.webkit.org/278798@main
@webkit-commit-queue
Copy link
Collaborator

Committed 278798@main (f54cee4): https://commits.webkit.org/278798@main

Reviewed commits have been landed. Closing PR #28579 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit f54cee4 into WebKit:main May 15, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 15, 2024
@aprotyas aprotyas deleted the eng/274189 branch June 4, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smfr smfr smfr approved these changes

@sammygill sammygill sammygill approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@aprotyas aprotyas

Labels
PDF For bugs in WebKit's built-in PDF support.
Projects
None yet
Milestone
No milestone
6 participants
@aprotyas @webkit-early-warning-system @webkit-commit-queue @smfr @sammygill @webkit-ews-buildbot