[WPE][GTK] Enable fatal criticals in WebKit subprocesses #28651
Conversation
https://bugs.webkit.org/show_bug.cgi?id=274255 Reviewed by NOBODY (OOPS!). Critical warnings should only be used to indicate programmer error. By default, they are "soft assertions" that allow program execution to continue even though we know the process is no lonnger operating correctly because a bug has occurred. This is a bad default. Let's crash instead, to make it easier to debug the problem, encourage bug reports, and downgrade any code execution issues into denial of service. This will significantly increase crashes in our multimedia code. I think the rest of WebKit is more or less in good state, but there will certainly be more crashes here and there. I'm confident it will be worth it! We cannot do this in the UI process because that decision should be left up to the application. Only do this for subprocesses. * Source/WebKit/Shared/unix/AuxiliaryProcessMain.cpp: (WebKit::ignoreSigpipe): (WebKit::AuxiliaryProcess::platformInitialize):
|
EWS run on current version of this PR (hash 807cbc0) |
|
Criticals can come from other glib dependencies, I don't think we want to crash our web process after a dependency update because of a critical that is not ours. |
Yes.
We could make criticals fatal only for our own log domain. (We actually don't currently have a log domain for WebKit? Really should define one using But I'd strongly prefer to crash on bugs in our dependencies as well. E.g. The motivating case for this today was this bug and the critical there is coming from GStreamer. |
|
I don't think it's a good idea, you can get a web process crash because of other dependency and there's no way to get you browser working, even when it's fully functional, until your distro or sdk is updated. |
|
Well, that was my goal. If you don't want to do it, there's no point in keeping this open. I'll do it in the Epiphany web process extension instead. |
I proposed this for WebKit in WebKit/WebKit#28651 but Carlos is reluctant, so let's do it only for Epiphany. Unfortunately there's no way to block criticals in the network process (or the future GPU process) without using the G_DEBUG environment variable. Too bad.
I proposed this for WebKit in WebKit/WebKit#28651 but Carlos is reluctant, so let's do it only for Epiphany. Unfortunately there's no way to block criticals in the network process (or the future GPU process) without using the G_DEBUG environment variable. Too bad. Part-of: <https://gitlab.gnome.org/GNOME/epiphany/-/merge_requests/1488>
807cbc0
807cbc0