[git-webkit] Disable commit signing by default in WebKit #28857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonWBedard
added
the
Tools / Tests
|
EWS run on previous version of this PR (hash 88e19ae)
|
emw-apple
approved these changes
May 21, 2024
Will add that to the commit message. |
JonWBedard
force-pushed
the
eng/git-webkit-Disable-commit-signing-by-default-in-WebKit
branch
from
88e19ae
to
8a3e790
Compare
|
EWS run on current version of this PR (hash 8a3e790)
|
JonWBedard
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=274474 rdar://128477412 Reviewed by Dewei Zhu and Elliott Williams. Commit signatures are blown away by merge-queue. As long as this remains true, the WebKit project explicitly does not support commit signing, our default git configuration should make that obvious. * metadata/git_config_extension: Disable commit signing. Canonical link: https://commits.webkit.org/279068@main
webkit-commit-queue
force-pushed
the
eng/git-webkit-Disable-commit-signing-by-default-in-WebKit
branch
from
8a3e790
to
154e658
Compare
|
Committed 279068@main (154e658): https://commits.webkit.org/279068@main Reviewed commits have been landed. Closing PR #28857 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
JonWBedard
deleted the
eng/git-webkit-Disable-commit-signing-by-default-in-WebKit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
154e658
8a3e790
🛠 ios🛠 mac🛠 wpe🛠 wincairo🛠 ios-sim🛠 mac-AS-debug🧪 wpe-wk2🧪 wincairo-tests🧪 webkitperl🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk1🛠 wpe-cairo🧪 api-ios🧪 mac-wk2🛠 gtk🛠 tv🧪 mac-AS-debug-wk2🧪 gtk-wk2🛠 tv-sim🧪 mac-wk2-stress🧪 api-gtk🛠 watch🛠 watch-sim