srcdoc iframes fail to clear when srcdoc attribute removed #2889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rniwa
added
Frames
darinadler
approved these changes
Jul 31, 2022
https://bugs.webkit.org/show_bug.cgi?id=243385 Reviewed by Darin Adler. The bug was caused by the superfluous null string check in HTMLFrameElementBase::parseAttribute in the case of srcdoc being a null string. When both src and srcdoc are both, we should navigate to about:blank instead. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/srcdoc-attribute-reset-expected.txt: * Source/WebCore/html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::parseAttribute): Canonical link: https://commits.webkit.org/252991@main
webkit-early-warning-system
force-pushed
the
fix243385
branch
from
5cfbbdf
to
e540252
Compare
|
Committed 252991@main (e540252): https://commits.webkit.org/252991@main Reviewed commits have been landed. Closing PR #2889 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e540252