Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build.webkit.org] Do not try to download build product from master #28931

Conversation

aj062
Copy link
Member

@aj062 aj062 commented May 22, 2024

538cc4d

[build.webkit.org] Do not try to download build product from master
https://bugs.webkit.org/show_bug.cgi?id=274538

Reviewed by Ryan Haddad.

We stopped uploading archives to build master in 276500@main.So, while downloading
archives, when download from s3 fails, there is no point in trying to fallback to
download from build master.

We should make it a hard failure when download from s3 fails.
This is similar to 276539@main for ews.

* Tools/CISupport/build-webkit-org/steps.py:
(DownloadBuiltProduct):

Canonical link: https://commits.webkit.org/279145@main

ab35a92

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac   πŸ›  wpe   πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug   πŸ§ͺ wpe-wk2   πŸ§ͺ wincairo-tests
βœ… πŸ§ͺ webkitperl   πŸ§ͺ ios-wk2   πŸ§ͺ api-mac   πŸ§ͺ api-wpe
  πŸ§ͺ ios-wk2-wpt   πŸ§ͺ mac-wk1   πŸ›  wpe-cairo
  πŸ§ͺ api-ios   πŸ§ͺ mac-wk2   πŸ›  gtk
  πŸ›  tv   πŸ§ͺ mac-AS-debug-wk2   πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ services   πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2-stress   πŸ§ͺ api-gtk
  πŸ›  watch
βœ… πŸ›  πŸ§ͺ unsafe-merge   πŸ›  watch-sim

@aj062 aj062 self-assigned this May 22, 2024
@aj062 aj062 added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label May 22, 2024
@aj062 aj062 added the skip-ews Applied to prevent a change from being run on EWS label May 22, 2024
@aj062 aj062 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 22, 2024
https://bugs.webkit.org/show_bug.cgi?id=274538

Reviewed by Ryan Haddad.

We stopped uploading archives to build master in 276500@main.So, while downloading
archives, when download from s3 fails, there is no point in trying to fallback to
download from build master.

We should make it a hard failure when download from s3 fails.
This is similar to 276539@main for ews.

* Tools/CISupport/build-webkit-org/steps.py:
(DownloadBuiltProduct):

Canonical link: https://commits.webkit.org/279145@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/build-webkit-org-Do-not-try-to-download-build-product-from-master branch from ab35a92 to 538cc4d Compare May 22, 2024 19:12
@webkit-commit-queue
Copy link
Collaborator

Committed 279145@main (538cc4d): https://commits.webkit.org/279145@main

Reviewed commits have been landed. Closing PR #28931 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 538cc4d into WebKit:main May 22, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 22, 2024
@aj062 aj062 deleted the eng/build-webkit-org-Do-not-try-to-download-build-product-from-master branch June 7, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ews Applied to prevent a change from being run on EWS Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
4 participants