Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ visionOS Debug ] ASSERTION FAILED: parentProcessHasServiceWorkerEntitlement() || shouldAllowServiceWorkersForAppBoundViews #29082

Merged
merged 1 commit into from
May 24, 2024
Merged

[ visionOS Debug ] ASSERTION FAILED: parentProcessHasServiceWorkerEntitlement() || shouldAllowServiceWorkersForAppBoundViews #29082

merged 1 commit into from
May 24, 2024

Conversation

robert-jenner
Copy link
Contributor

@robert-jenner robert-jenner commented May 24, 2024 •
edited by webkit-early-warning-system

92bcd77

[ visionOS Debug ] ASSERTION FAILED: parentProcessHasServiceWorkerEntitlement() || shouldAllowServiceWorkersForAppBoundViews
https://bugs.webkit.org/show_bug.cgi?id=274629
rdar://128651013

Reviewed by Elliott Williams.

Adding iOS entitlements for visionOS.

* Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:

Canonical link: https://commits.webkit.org/279299@main

e7b9f41

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🛠 tv-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
✅ 🛠 🧪 merge   🛠 watch
✅ 🛠 watch-sim

@robert-jenner robert-jenner self-assigned this May 24, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash e7b9f41)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🛠 tv-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
✅ 🛠 🧪 merge   🛠 watch
✅ 🛠 watch-sim

@robert-jenner robert-jenner added the WebKit Process Model Bugs related to WebKit's multi-process architecture label May 24, 2024
@robert-jenner robert-jenner added the merge-queue Applied to send a pull request to merge-queue label May 24, 2024
@robert-jenner
[ visionOS Debug ] ASSERTION FAILED: parentProcessHasServiceWorkerEnt…
92bcd77 
…itlement() || shouldAllowServiceWorkersForAppBoundViews

https://bugs.webkit.org/show_bug.cgi?id=274629
rdar://128651013

Reviewed by Elliott Williams.

Adding iOS entitlements for visionOS.

* Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:

Canonical link: https://commits.webkit.org/279299@main
@webkit-commit-queue
Copy link
Collaborator

Committed 279299@main (92bcd77): https://commits.webkit.org/279299@main

Reviewed commits have been landed. Closing PR #29082 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 92bcd77 into WebKit:main May 24, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 24, 2024
@robert-jenner robert-jenner deleted the eng/128651013 branch June 3, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emw-apple emw-apple emw-apple approved these changes

Assignees

@robert-jenner robert-jenner

Labels
WebKit Process Model Bugs related to WebKit's multi-process architecture
Projects
None yet
Milestone
No milestone
4 participants
@robert-jenner @webkit-early-warning-system @webkit-commit-queue @emw-apple