Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REGRESSION(273818@main): [GTK] Eclipse crashes when rendering tooltips: gdk_window_create_gl_context: assertion 'GDK_IS_WINDOW (window)' failed in WebKit::AcceleratedBackingStoreDMABuf::ensureGLContext #29811

Merged
merged 1 commit into from
Jun 20, 2024
Merged

REGRESSION(273818@main): [GTK] Eclipse crashes when rendering tooltips: gdk_window_create_gl_context: assertion 'GDK_IS_WINDOW (window)' failed in WebKit::AcceleratedBackingStoreDMABuf::ensureGLContext #29811

merged 1 commit into from
Jun 20, 2024
+6 −9

Conversation

carlosgcampos
Copy link
Contributor

@carlosgcampos carlosgcampos commented Jun 14, 2024 •
edited by webkit-early-warning-system
Loading

847b2a7

REGRESSION(273818@main): [GTK] Eclipse crashes when rendering tooltips: gdk_window_create_gl_context: assertion 'GDK_IS_WINDOW (window)' failed in WebKit::AcceleratedBackingStoreDMABuf::ensureGLContext
https://bugs.webkit.org/show_bug.cgi?id=271477

Reviewed by Adrian Perez de Castro.

Update the buffer contents on prepareForRendering to make sure the view
is already realized, which is required to create the gl context.

* Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp:
(WebKit::AcceleratedBackingStoreDMABuf::frame):
(WebKit::AcceleratedBackingStoreDMABuf::prepareForRendering):

Canonical link: https://commits.webkit.org/280197@main

3ec05c6

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@carlosgcampos carlosgcampos requested a review from a team as a code owner June 14, 2024 07:57
@carlosgcampos carlosgcampos self-assigned this Jun 14, 2024
@carlosgcampos carlosgcampos added the WebKitGTK Bugs related to the Gtk API layer. label Jun 14, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jun 14, 2024 •
edited
Loading

EWS run on current version of this PR (hash 3ec05c6)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@oreo639
Copy link

oreo639 commented Jun 14, 2024 •
edited
Loading

This patch does appear to resolve the crashing with eclipse and nyxt for me.

@carlosgcampos carlosgcampos added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 20, 2024
@carlosgcampos
REGRESSION(273818@main): [GTK] Eclipse crashes when rendering tooltip…
847b2a7 
…s: gdk_window_create_gl_context: assertion 'GDK_IS_WINDOW (window)' failed in WebKit::AcceleratedBackingStoreDMABuf::ensureGLContext

https://bugs.webkit.org/show_bug.cgi?id=271477

Reviewed by Adrian Perez de Castro.

Update the buffer contents on prepareForRendering to make sure the view
is already realized, which is required to create the gl context.

* Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp:
(WebKit::AcceleratedBackingStoreDMABuf::frame):
(WebKit::AcceleratedBackingStoreDMABuf::prepareForRendering):

Canonical link: https://commits.webkit.org/280197@main
@webkit-commit-queue
Copy link
Collaborator

Committed 280197@main (847b2a7): https://commits.webkit.org/280197@main

Reviewed commits have been landed. Closing PR #29811 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 847b2a7 into WebKit:main Jun 20, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 20, 2024
@carlosgcampos carlosgcampos deleted the wkgtk-ensure-gl-realized branch June 20, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aperezdc aperezdc aperezdc approved these changes

Assignees

@carlosgcampos carlosgcampos

Labels
WebKitGTK Bugs related to the Gtk API layer.
Projects
None yet
Milestone
No milestone
5 participants
@carlosgcampos @webkit-early-warning-system @oreo639 @webkit-commit-queue @aperezdc