Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a parenting issue in the Adoption Agency Algorithm #3053

Merged
merged 1 commit into from Aug 5, 2022
Merged

Fix a parenting issue in the Adoption Agency Algorithm #3053

merged 1 commit into from Aug 5, 2022

Conversation

rniwa
Copy link
Member

@rniwa rniwa commented Aug 5, 2022 •
edited by webkit-commit-queue

2e20c7f

Fix a parenting issue in the Adoption Agency Algorithm
https://bugs.webkit.org/show_bug.cgi?id=243599

Reviewed by Chris Dumez.

Exit early when the child-to-be contains the new parent.

* Source/WebCore/html/parser/HTMLConstructionSite.cpp:
(WebCore::executeReparentTask):
(WebCore::executeInsertAlreadyParsedChildTask):

Canonical link: https://commits.webkit.org/253155@main

@rniwa rniwa requested a review from cdumez as a code owner August 5, 2022 19:21
@rniwa rniwa self-assigned this Aug 5, 2022
@rniwa rniwa added DOM For bugs specific to XML/HTML DOM elements (including parsing). WebKit Nightly Build labels Aug 5, 2022
cdumez
cdumez approved these changes Aug 5, 2022
View reviewed changes
Copy link
Contributor

@cdumez cdumez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rniwa rniwa added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 5, 2022
@rniwa
Fix a parenting issue in the Adoption Agency Algorithm
2e20c7f 
https://bugs.webkit.org/show_bug.cgi?id=243599

Reviewed by Chris Dumez.

Exit early when the child-to-be contains the new parent.

* Source/WebCore/html/parser/HTMLConstructionSite.cpp:
(WebCore::executeReparentTask):
(WebCore::executeInsertAlreadyParsedChildTask):

Canonical link: https://commits.webkit.org/253155@main
@webkit-commit-queue
Copy link
Collaborator

Committed 253155@main (2e20c7f): https://commits.webkit.org/253155@main

Reviewed commits have been landed. Closing PR #3053 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 2e20c7f into WebKit:main Aug 5, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 5, 2022
@rniwa rniwa deleted the fix243599 branch August 5, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez cdumez approved these changes

Assignees

@rniwa rniwa

Labels
DOM For bugs specific to XML/HTML DOM elements (including parsing).
Projects
None yet
Milestone
No milestone
4 participants
@rniwa @webkit-commit-queue @cdumez @webkit-early-warning-system