Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GTK] fast/mediastream/media-element-current-time.html is failing since added in r256346 #3085

Merged
merged 1 commit into from Aug 8, 2022

Conversation

philn
Copy link
Member

@philn philn commented Aug 7, 2022

3e994a2

[GTK] fast/mediastream/media-element-current-time.html is failing since added in r256346
https://bugs.webkit.org/show_bug.cgi?id=208120
<rdar://problem/86967699>

Reviewed by Eric Carlson.

* LayoutTests/fast/mediastream/media-element-current-time.html: Rely on events and rvFc to ensure
the test behavior is consistent.

Canonical link: https://commits.webkit.org/253220@main

@philn philn self-assigned this Aug 7, 2022
@philn philn added New Bugs Unclassified bugs are placed in this component until the correct component can be determined. WebKit Nightly Build labels Aug 7, 2022
@dpino
Copy link
Contributor

dpino commented Aug 8, 2022

LGTM.

Copy link
Contributor

@eric-carlson eric-carlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement, thanks.

r=me

@philn philn added the merge-queue Applied to send a pull request to merge-queue label Aug 8, 2022
…ce added in r256346

https://bugs.webkit.org/show_bug.cgi?id=208120
<rdar://problem/86967699>

Reviewed by Eric Carlson.

* LayoutTests/fast/mediastream/media-element-current-time.html: Rely on events and rvFc to ensure
the test behavior is consistent.

Canonical link: https://commits.webkit.org/253220@main
@webkit-commit-queue
Copy link
Collaborator

Committed 253220@main (3e994a2): https://commits.webkit.org/253220@main

Reviewed commits have been landed. Closing PR #3085 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 3e994a2 into WebKit:main Aug 8, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 8, 2022
@philn philn deleted the eng/208120 branch August 8, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
5 participants