readonly attribute should only apply on certain input types #3115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nt1m
added
Forms
nt1m
force-pushed
the
readonly
branch
2 times, most recently
from
865802e
to
0a800d6
Compare
pxlcoder
reviewed
Aug 8, 2022
nt1m
commented
Aug 9, 2022
webkit-ews-buildbot
added
the
merging-blocked
nt1m
force-pushed
the
readonly
branch
2 times, most recently
from
ca7e887
to
5b53401
Compare
webkit-ews-buildbot
added
the
merging-blocked
webkit-early-warning-system
force-pushed
the
readonly
branch
from
a835cf7
to
f633a6e
Compare
https://bugs.webkit.org/show_bug.cgi?id=240343 <rdar://93173726> Reviewed by Chris Dumez. We should only apply the readonly attribute on certain input types: https://html.spec.whatwg.org/multipage/input.html#do-not-apply Except in the constraint validation case (willValidate) for compat reasons, since it affects the :in-range/:out-of-range pseudo-classes, the relevant test has been updated to reflect that. This also was the resolution of whatwg/html#8133 in the HTML spec triage meeting. Also introduce isMutable() which corresponds to the spec concept of mutable form control. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-disabled-readonly-expected.txt: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-disabled-readonly-expected.txt: Added. * Source/WebCore/html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::valueMissing const): (WebCore::BaseDateAndTimeInputType::handleDOMActivateEvent): * Source/WebCore/html/ColorInputType.cpp: (WebCore::ColorInputType::isKeyboardFocusable const): * Source/WebCore/html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::HTMLFormControlElement): (WebCore::HTMLFormControlElement::parseAttribute): (WebCore::HTMLFormControlElement::computeWillValidate const): * Source/WebCore/html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::supportsReadOnly const): (WebCore::HTMLFormControlElement::isReadOnly const): (WebCore::HTMLFormControlElement::isMutable const): (WebCore::HTMLFormControlElement::isDisabledOrReadOnly const): Deleted. * Source/WebCore/html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateType): (WebCore::HTMLInputElement::supportsReadOnly const): (WebCore::HTMLInputElement::showPicker): (WebCore::HTMLInputElement::matchesReadWritePseudoClass const): (WebCore::HTMLInputElement::createInnerTextStyle): * Source/WebCore/html/HTMLInputElement.h: * Source/WebCore/html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::matchesReadWritePseudoClass const): * Source/WebCore/html/HTMLTextAreaElement.h: * Source/WebCore/html/HTMLTextFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::isInnerTextElementEditable const): * Source/WebCore/html/SearchInputType.cpp: (WebCore::SearchInputType::handleKeydownEvent): * Source/WebCore/html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::valueMissing const): (WebCore::TextFieldInputType::handleKeydownEventForSpinButton): (WebCore::TextFieldInputType::shouldSpinButtonRespondToMouseEvents const): (WebCore::TextFieldInputType::shouldDrawCapsLockIndicator const): (WebCore::TextFieldInputType::shouldDrawAutoFillButton const): * Source/WebCore/html/shadow/SliderThumbElement.cpp: (WebCore::SliderThumbElement::handleTouchEvent): * Source/WebCore/html/shadow/TextControlInnerElements.cpp: (WebCore::SearchFieldCancelButtonElement::defaultEventHandler): (WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEventsWithEditability const): Canonical link: https://commits.webkit.org/253321@main
webkit-early-warning-system
force-pushed
the
readonly
branch
from
f633a6e
to
af43ca3
Compare
|
Committed 253321@main (af43ca3): https://commits.webkit.org/253321@main Reviewed commits have been landed. Closing PR #3115 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
af43ca3