iframe srcdoc with quirky doctype should be no-quirks mode #3199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rniwa
added
DOM
cdumez
reviewed
Aug 10, 2022
LayoutTests/fast/parser/strict-mode-in-srcdoc-with-quirks-doctype-expected.txt
Outdated
Show resolved
Hide resolved
cdumez
approved these changes
Aug 10, 2022
webkit-ews-buildbot
added
the
merging-blocked
rniwa
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=159489 Reviewed by Chris Dumez. This patch addresses the bug that a document in srcdoc can be in quirks mode due to DOCTYPE. New behavior of WebKit matches the spec, Gecko, and Blink. * LayoutTests/fast/parser/strict-mode-in-srcdoc-with-quirks-doctype-expected.txt: Added. * LayoutTests/fast/parser/strict-mode-in-srcdoc-with-quirks-doctype.html: Added. * LayoutTests/fast/frames/srcdoc/srcdoc-can-be-in-qurks-mode-expected.txt: * Source/WebCore/html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::setCompatibilityModeFromDoctype): (WebCore::HTMLConstructionSite::insertDoctype): Canonical link: https://commits.webkit.org/253326@main
webkit-early-warning-system
force-pushed
the
fix159489
branch
from
be5d186
to
4401d4e
Compare
|
Committed 253326@main (4401d4e): https://commits.webkit.org/253326@main Reviewed commits have been landed. Closing PR #3199 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4401d4e