[WebAuthn] Disable platform authenticator for disallowed rps #3239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascoej
added
WebKit Misc.
pascoej
force-pushed
the
eng/WebAuthn-Disable-platform-authenticator-for-disallowed-rps
branch
from
d799d98
to
51f5387
Compare
webkit-ews-buildbot
added
the
merging-blocked
brentfulgham
approved these changes
Aug 16, 2022
| @@ -32,6 +32,8 @@ | |||
| #else | |||
| @interface ASCWebKitSPISupport : NSObject | |||
| @property (class, nonatomic) BOOL shouldUseAlternateCredentialStore; | |||
| + (BOOL)arePasskeysDisallowedForRelyingParty:(nonnull NSString *)relyingParty; | |||
| + (void)getArePasskeysDisallowedForRelyingParty:(nonnull NSString *)relyingParty withCompletionHandler:(nonnull void (^)(BOOL))completionHandler; | |||
There was a problem hiding this comment.
You don't seem to use the getArePasskeysDisallowedForRelyingParty method, so may not be necessary to forward-declare it.
pascoej
removed
the
merging-blocked
pascoej
force-pushed
the
eng/WebAuthn-Disable-platform-authenticator-for-disallowed-rps
branch
from
51f5387
to
7247cd3
Compare
https://bugs.webkit.org/show_bug.cgi?id=243844 <rdar://97789464> Reviewed by Brent Fulgham. In some circumstances it may be useful to quirk off the platform authenticator for given rps. This patch hooks up some new internal SPI for that purpose. * Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp: (WebCore::AuthenticatorCoordinator::isUserVerifyingPlatformAuthenticatorAvailable const): * Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.h: * Source/WebCore/Modules/webauthn/AuthenticatorCoordinatorClient.h: * Source/WebCore/Modules/webauthn/PublicKeyCredential.cpp: (WebCore::PublicKeyCredential::isUserVerifyingPlatformAuthenticatorAvailable): * Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h: * Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm: * Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp: (WebKit::WebAuthenticatorCoordinatorProxy::isUserVerifyingPlatformAuthenticatorAvailable): * Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h: * Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.messages.in: * Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp: (WebKit::WebAuthenticatorCoordinator::isUserVerifyingPlatformAuthenticatorAvailable): * Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.h: Canonical link: https://commits.webkit.org/253497@main
webkit-early-warning-system
force-pushed
the
eng/WebAuthn-Disable-platform-authenticator-for-disallowed-rps
branch
from
7247cd3
to
6bd8e23
Compare
|
Committed 253497@main (6bd8e23): https://commits.webkit.org/253497@main Reviewed commits have been landed. Closing PR #3239 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6bd8e23