Web Inspector: Network Tab: add reference page links #3252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcrousso
added
Web Inspector
|
🧪 ios-wk2
patrickangle
approved these changes
Aug 16, 2022
|
dcrousso
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=243861 Reviewed by Patrick Angle. * Source/WebInspectorUI/UserInterface/Base/ReferencePage.js: * Source/WebInspectorUI/UserInterface/Views/NetworkResourceDetailView.js: (WI.NetworkResourceDetailView.prototype.get referencePage): Added. * Source/WebInspectorUI/UserInterface/Views/ResourceCookiesContentView.js: * Source/WebInspectorUI/UserInterface/Views/ResourceHeadersContentView.js: * Source/WebInspectorUI/UserInterface/Views/ResourceSecurityContentView.js: * Source/WebInspectorUI/UserInterface/Views/ResourceSizesContentView.js: * Source/WebInspectorUI/UserInterface/Views/ResourceTimingContentView.js: Add a `ReferencePage` property to each class. * Source/WebInspectorUI/UserInterface/Views/NetworkDetailView.js: (WI.NetworkDetailView.prototype.initialLayout): (WI.NetworkDetailView.prototype._handleCurrentContentViewDidChange): Added. Propagate `WI.ContentBrowser.Event.CurrentContentViewDidChange` so that callers can know to grab the new `referencePage` value. * Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js: (WI.NetworkTableContentView.prototype.initialLayout): (WI.NetworkTableContentView.prototype._hideDetailView): (WI.NetworkTableContentView.prototype._showDetailView): (WI.NetworkTableContentView.prototype._handleCurrentResourceDetailViewDidChange): * Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css: (.network-table .reference-page-link-container): Added. Add a reference page link in the right of the statistics bar. Update it if the detail view changes. * Source/WebInspectorUI/UserInterface/Views/CreateAuditPopover.css: (.popover .create-audit-content > .editor-wrapper > .reference-page-link-container): Renamed from `.popover .create-audit-content > .editor-wrapper > .reference-page-link`. Drive-by: I noticed this was wrong while searching for related styles. Canonical link: https://commits.webkit.org/253477@main
webkit-early-warning-system
force-pushed
the
eng/243861
branch
from
a1c403f
to
cd47041
Compare
|
Committed 253477@main (cd47041): https://commits.webkit.org/253477@main Reviewed commits have been landed. Closing PR #3252 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cd47041
a1c403f
🛠 mac🛠 wpe🛠 🧪 win🛠 mac-debug🛠 gtk🛠 wincairo🧪 webkitperl🧪 ios-wk2🛠 mac-AS-debug🧪 api-gtk🧪 api-ios🧪 api-mac🛠 tv🧪 mac-wk1🧪 mac-wk2🧪 mac-AS-debug-wk2