[JSC][32bit] ASSERTION FAILED: !initialBytes #3275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikhailramalho
added
JavaScriptCore
mikhailramalho
force-pushed
the
eng/JSC32bit-ASSERTION-FAILED-initialBytes
branch
from
77aa9fd
to
a57c2ac
Compare
mikhailramalho
added
the
merge-queue
webkit-early-warning-system
force-pushed
the
eng/JSC32bit-ASSERTION-FAILED-initialBytes
branch
from
a57c2ac
to
d60c87c
Compare
https://bugs.webkit.org/show_bug.cgi?id=243901 Reviewed by Yusuke Suzuki. This patch fixes a value being truncated in 32bits platforms, resulting in a invalid maximum size. The method bytes() returns a uint64_t but in Memory::tryCreate, it is stored in size_t, which is fine in 64bit platforms but gets truncated in 32 bits ones. In this patch both initialBytes and maximumBytes are now uint64_t and there is an extra check if the maximum size is greater than what's allowed in the platform. * Source/JavaScriptCore/wasm/WasmMemory.cpp: (JSC::Wasm::Memory::tryCreate): Canonical link: https://commits.webkit.org/253399@main
webkit-early-warning-system
force-pushed
the
eng/JSC32bit-ASSERTION-FAILED-initialBytes
branch
from
d60c87c
to
3866ba7
Compare
|
Committed 253399@main (3866ba7): https://commits.webkit.org/253399@main Reviewed commits have been landed. Closing PR #3275 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3866ba7