Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PlayStation] Fix build after 251493@main #3282

Closed
wants to merge 1 commit into from

Conversation

basuke
Copy link
Contributor

@basuke basuke commented Aug 13, 2022

https://bugs.webkit.org/show_bug.cgi?id=243909

Unreviewed build fix for SERVICE_WORKER=Off.

m_serviceWorkerFetchTask is used without protecting by ENABLE(SERVICE_WORKER).

  • Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
    (WebKit::NetworkResourceLoader::didFinishWithRedirectResponse):

https://bugs.webkit.org/show_bug.cgi?id=243909

Unreviewed build fix for SERVICE_WORKER=Off.

m_serviceWorkerFetchTask is used without protecting by ENABLE(SERVICE_WORKER).

* Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didFinishWithRedirectResponse):
@basuke basuke requested a review from cdumez as a code owner August 13, 2022 00:35
@basuke basuke self-assigned this Aug 13, 2022
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 13, 2022
@youennf youennf added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Sep 1, 2022
@webkit-commit-queue
Copy link
Collaborator

This change contains multiple commits which are not squashed together, blocking PR #3282. Please squash the commits to land.

@webkit-commit-queue webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels Sep 1, 2022
@basuke basuke closed this Feb 9, 2023
@basuke basuke deleted the eng/243909 branch April 27, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merging-blocked Applied to prevent a change from being merged
Projects
None yet
5 participants