Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REGRESSION (238684@main, 985de701a): Add back fault logs when WebKit process calls exit() #3326

Merged
merged 1 commit into from Aug 16, 2022
Merged

REGRESSION (238684@main, 985de701a): Add back fault logs when WebKit process calls exit() #3326

merged 1 commit into from Aug 16, 2022

Conversation

ddkilzer
Copy link
Contributor

@ddkilzer ddkilzer commented Aug 15, 2022 •
edited by webkit-commit-queue

5738533

REGRESSION (238684@main, 985de701a): Add back fault logs when WebKit process calls exit()
https://bugs.webkit.org/show_bug.cgi?id=243955
<rdar://98689492>

Reviewed by Chris Dumez.

* Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:
(WebKit::XPCServiceEventHandler):
- Change RELEASE_LOG_ERROR() back to RELEASE_LOG_FAULT() when
  the WebKit process is about to call exit().

Canonical link: https://commits.webkit.org/253479@main

@ddkilzer ddkilzer self-assigned this Aug 15, 2022
@ddkilzer ddkilzer added WebKit Nightly Build WebKit2 Bugs relating to the WebKit2 API layer labels Aug 15, 2022
cdumez
cdumez approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@cdumez cdumez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ddkilzer
Copy link
Contributor Author

Closing this as it will cause issues with testers again (which is why It was changed before).

@ddkilzer ddkilzer closed this Aug 15, 2022
@ddkilzer
Copy link
Contributor Author

ddkilzer commented Aug 15, 2022 •
edited

Wait, I was looking at rdar://74087331, which claimed the fault logs caused tests to fail, but there were never any changes made for that issue.

Reopening this.

@ddkilzer ddkilzer reopened this Aug 15, 2022
@ddkilzer ddkilzer added the merge-queue Applied to send a pull request to merge-queue label Aug 16, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the ddkilzer/bug-243955-change-error-log-to-fault-log-on-exit branch from 5b8ad09 to 8d9c271 Compare August 16, 2022 03:01
@ddkilzer ddkilzer removed the merge-queue Applied to send a pull request to merge-queue label Aug 16, 2022
@ddkilzer ddkilzer force-pushed the ddkilzer/bug-243955-change-error-log-to-fault-log-on-exit branch from 8d9c271 to ca805d2 Compare August 16, 2022 15:19
@ddkilzer ddkilzer added the merge-queue Applied to send a pull request to merge-queue label Aug 16, 2022
@ddkilzer
Copy link
Contributor Author

ddkilzer commented Aug 16, 2022 •
edited

Not sure why this didn't land yesterday. I just tried rebasing it, but seems like I have to go through all the EWS bots again. ¯\(ツ)/¯

@webkit-commit-queue webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels Aug 16, 2022
@ddkilzer ddkilzer added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Aug 16, 2022
@ddkilzer
Copy link
Contributor Author

Failures in the merge bot testing were unrelated to this patch, but happened twice in a row (crash in the GPU process outside of WebKit for a bug that was fixed after the build that is on the bots).
https://ews-build.webkit.org/#/builders/74/builds/2475

@ddkilzer
Copy link
Contributor Author

So...do I need to force-push yet another PR to clear the bogus merge queue failure?

@ddkilzer ddkilzer removed the merge-queue Applied to send a pull request to merge-queue label Aug 16, 2022
@ddkilzer ddkilzer force-pushed the ddkilzer/bug-243955-change-error-log-to-fault-log-on-exit branch from ca805d2 to 98c6f96 Compare August 16, 2022 17:16
@ddkilzer ddkilzer added the merge-queue Applied to send a pull request to merge-queue label Aug 16, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the ddkilzer/bug-243955-change-error-log-to-fault-log-on-exit branch from 98c6f96 to 5220129 Compare August 16, 2022 20:17
@ddkilzer
REGRESSION (238684@main, 985de70): Add back fault logs when WebKit pr…
5738533 
…ocess calls exit()

https://bugs.webkit.org/show_bug.cgi?id=243955
<rdar://98689492>

Reviewed by Chris Dumez.

* Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:
(WebKit::XPCServiceEventHandler):
- Change RELEASE_LOG_ERROR() back to RELEASE_LOG_FAULT() when
  the WebKit process is about to call exit().

Canonical link: https://commits.webkit.org/253479@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the ddkilzer/bug-243955-change-error-log-to-fault-log-on-exit branch from 5220129 to 5738533 Compare August 16, 2022 20:19
@webkit-early-warning-system webkit-early-warning-system merged commit 5738533 into WebKit:main Aug 16, 2022
@webkit-commit-queue
Copy link
Collaborator

Committed 253479@main (5738533): https://commits.webkit.org/253479@main

Reviewed commits have been landed. Closing PR #3326 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 16, 2022
@ddkilzer ddkilzer deleted the ddkilzer/bug-243955-change-error-log-to-fault-log-on-exit branch September 18, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez cdumez approved these changes

@achristensen07 achristensen07 Awaiting requested review from achristensen07

Assignees

@ddkilzer ddkilzer

Labels
WebKit2 Bugs relating to the WebKit2 API layer
Projects
None yet
Milestone
No milestone
4 participants
@ddkilzer @webkit-commit-queue @cdumez @webkit-early-warning-system