WebProcessProxy should keep WebsiteDataStore alive #3331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achristensen07
added
WebKit Nightly Build
WebKit Process Model
achristensen07
force-pushed
the
eng/WebProcessProxy-should-keep-WebsiteDataStore-alive
branch
from
c9f2c52
to
4d443fb
Compare
cdumez
approved these changes
Aug 15, 2022
| if (!dataStore) | ||
| return reply({ }); | ||
|
|
||
| RELEASE_ASSERT(dataStore); |
There was a problem hiding this comment.
This looks very dangerous. If this happened, we'd be converting a WebContent process crash into a UIProcess crash, which is not a good trade off IMO. I'd recommend a debug ASSERT() instead and a RELEASE_LOG_FAULT() so we know it's happening.
achristensen07
force-pushed
the
eng/WebProcessProxy-should-keep-WebsiteDataStore-alive
branch
from
4d443fb
to
d38fc18
Compare
achristensen07
added
the
merge-queue
webkit-early-warning-system
force-pushed
the
eng/WebProcessProxy-should-keep-WebsiteDataStore-alive
branch
from
d38fc18
to
7677d62
Compare
https://bugs.webkit.org/show_bug.cgi?id=243960 <rdar://98313174> Reviewed by Chris Dumez. This effectively reverts bug 238892 because it caused rdar://98313174 Tasks such as the one scheduled in WorkerSWClientConnection::unregisterServiceWorkerClient need a connection to the network process, and if the network process has crashed then they need a WebsiteDataStore to restart that network process, so a WebProcessProxy needs to keep a WebsiteDataStore alive. * Source/WebKit/UIProcess/WebProcessProxy.cpp: (WebKit::m_webPermissionController): (WebKit::WebProcessProxy::setWebsiteDataStore): (WebKit::WebProcessProxy::isDummyProcessProxy const): (WebKit::WebProcessProxy::addExistingWebPage): (WebKit::WebProcessProxy::getNetworkProcessConnection): (WebKit::WebProcessProxy::sessionID const): (WebKit::WebProcessProxy::websiteDataStore const): Deleted. * Source/WebKit/UIProcess/WebProcessProxy.h: (WebKit::WebProcessProxy::websiteDataStore const): Canonical link: https://commits.webkit.org/253449@main
webkit-early-warning-system
force-pushed
the
eng/WebProcessProxy-should-keep-WebsiteDataStore-alive
branch
from
7677d62
to
2cd7eec
Compare
|
Committed 253449@main (2cd7eec): https://commits.webkit.org/253449@main Reviewed commits have been landed. Closing PR #3331 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2cd7eec