Commits on Aug 18, 2022

1. LibraryPathDiagnostics prints UUIDs with bytes in the reverse order …

   https://bugs.webkit.org/show_bug.cgi?id=244011
   rdar://98737098
   
   Reviewed by Saam Barati.
   
   In https://bugs.webkit.org/show_bug.cgi?id=243458, I added code in LibraryPathDiagnostics that
   attempts to convert `uuid_t` returned by DYLD API to `WTF::UUID`, but I didn't realize that these
   two types don't agree on endianness -- the former appears to be big-endian while the latter is
   little-endian. The natural consequence of this is that the UUIDs printed in the logs are shown
   with their bytes in the reverse order of what they should be.
   
   Fix this by removing the conversion between the two UUID types altogether, and simply use the
   platform API `uuid_unparse()` to produce the string representations of `uuid_t`s. Considering
   how infrequently this type is used in the WebKit codebase (this is the second usage of this
   type, other than ProcessLauncherCocoa), I chose to implement this as a local helper function
   rather than building this conversion into WTF's UUID type directly. Doing so would require
   either building in the assumption that `uuid_t` is stored big-endian on all platforms, or we'd
   need to use an inefficient implementation that performs this conversion by round-tripping the
   UUID through a string representation. This conversion isn't actually needed at the moment, so
   I'd rather not do either of those when the tool already exists to do what *actually* needs to
   be done -- convert the `uuid_t` to a string.
   
   * Source/WTF/wtf/darwin/LibraryPathDiagnostics.mm:
   (WTF::uuidToString):
   (WTF::LibraryPathDiagnosticsLogger::logDYLDSharedCacheInfo):
   (WTF::LibraryPathDiagnosticsLogger::logDynamicLibraryInfo):
   
   Canonical link: https://commits.webkit.org/253545@main

   

   davidquesada committed Aug 18, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 2fe54ca
   • Browse repository at this point

   Copy the full SHA

   2fe54ca View commit details

   Browse the repository at this point in the history