Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ews] Display waiting icon in status-bubble when a change is waiting in tester queue #3453

Merged
merged 1 commit into from Aug 18, 2022
Merged

[ews] Display waiting icon in status-bubble when a change is waiting in tester queue #3453

merged 1 commit into from Aug 18, 2022

Conversation

aj062
Copy link
Member

@aj062 aj062 commented Aug 18, 2022 •
edited by webkit-early-warning-system

a6bf1d8

[ews] Display waiting icon in status-bubble when a change is waiting in tester queue
https://bugs.webkit.org/show_bug.cgi?id=244088

Reviewed by Jonathan Bedard.

* Tools/CISupport/ews-app/ews/common/github.py:
(GitHubEWS.github_status_for_queue):

Canonical link: https://commits.webkit.org/253560@main

91d7220

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@aj062 aj062 self-assigned this Aug 18, 2022
@aj062 aj062 added Other Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases labels Aug 18, 2022
@aj062 aj062 assigned aproskuryakov and unassigned aproskuryakov Aug 18, 2022
@webkit-early-warning-system
Copy link
Collaborator

91d7220

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@aj062 aj062 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 18, 2022
@aj062
[ews] Display waiting icon in status-bubble when a change is waiting …
a6bf1d8 
…in tester queue

https://bugs.webkit.org/show_bug.cgi?id=244088

Reviewed by Jonathan Bedard.

* Tools/CISupport/ews-app/ews/common/github.py:
(GitHubEWS.github_status_for_queue):

Canonical link: https://commits.webkit.org/253560@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/ews-Display-waiting-icon-in-status-bubble-when-a-change-is-waiting-in-tester-queue branch from 91d7220 to a6bf1d8 Compare August 18, 2022 15:58
@webkit-commit-queue
Copy link
Collaborator

Committed 253560@main (a6bf1d8): https://commits.webkit.org/253560@main

Reviewed commits have been landed. Closing PR #3453 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit a6bf1d8 into WebKit:main Aug 18, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 18, 2022
@aj062 aj062 deleted the eng/ews-Display-waiting-icon-in-status-bubble-when-a-change-is-waiting-in-tester-queue branch August 18, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonWBedard JonWBedard JonWBedard approved these changes

@ryanhaddad ryanhaddad Awaiting requested review from ryanhaddad ryanhaddad is a code owner

@aproskuryakov aproskuryakov Awaiting requested review from aproskuryakov

Assignees

@aj062 aj062

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
5 participants
@aj062 @webkit-early-warning-system @webkit-commit-queue @JonWBedard @aproskuryakov