Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unreviewed non-unified build fixes #3499

Merged
merged 1 commit into from Aug 20, 2022
Merged

Unreviewed non-unified build fixes #3499

merged 1 commit into from Aug 20, 2022

Conversation

aperezdc
Copy link
Contributor

@aperezdc aperezdc commented Aug 20, 2022 •
edited by webkit-early-warning-system

760ccfb

Unreviewed non-unified build fixes

* Source/WebCore/animation/DocumentTimeline.cpp: Add missing Logging.h
  header inclusion.
* Source/WebKit/UIProcess/Notifications/glib/NotificationService.cpp:
  Add missing cairo.h header inclusion.

Canonical link: https://commits.webkit.org/253616@main

8faa328

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@aperezdc aperezdc requested review from a team and graouts as code owners August 20, 2022 13:03
@aperezdc aperezdc self-assigned this Aug 20, 2022
@webkit-early-warning-system
Copy link
Collaborator

8faa328

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@aperezdc aperezdc added the merge-queue Applied to send a pull request to merge-queue label Aug 20, 2022
@aperezdc
Unreviewed non-unified build fixes
760ccfb 
* Source/WebCore/animation/DocumentTimeline.cpp: Add missing Logging.h
  header inclusion.
* Source/WebKit/UIProcess/Notifications/glib/NotificationService.cpp:
  Add missing cairo.h header inclusion.

Canonical link: https://commits.webkit.org/253616@main
@webkit-commit-queue
Copy link
Collaborator

Committed 253616@main (760ccfb): https://commits.webkit.org/253616@main

Reviewed commits have been landed. Closing PR #3499 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 760ccfb into WebKit:main Aug 20, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 20, 2022
@aperezdc aperezdc deleted the eng/nonunified2208e branch August 20, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graouts graouts Awaiting requested review from graouts graouts is a code owner

Assignees

@aperezdc aperezdc

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@aperezdc @webkit-early-warning-system @webkit-commit-queue