Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flatpak SDK] Enable openh264 GStreamer plugin #3503

Merged
merged 1 commit into from Aug 21, 2022

Conversation

philn
Copy link
Member

@philn philn commented Aug 20, 2022

265bd1b

[Flatpak SDK] Enable openh264 GStreamer plugin
https://bugs.webkit.org/show_bug.cgi?id=244158

Reviewed by Adrian Perez de Castro.

This encoder claims to support the constrained-high profile whereas x264enc doesn't, so this encoder
will be used for some WebRTC layout tests requiring that profile.

* Tools/buildstream/elements/sdk/gst-plugins-bad.bst:
* Tools/buildstream/elements/sdk/libopenh264.bst:
* Tools/buildstream/patches/gst-plugins-bad-openh264-Register-debug-categories-earlier.patch: Added.
* Tools/buildstream/patches/gst-plugins-bad-openh264enc-Fix-constrained-high-encoding.patch: Added.

Canonical link: https://commits.webkit.org/253627@main

5303dd7

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  πŸ§ͺ win
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-debug βœ… πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk1
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  watch βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  πŸ§ͺ unsafe-merge βœ… πŸ›  watch-sim βœ… πŸ§ͺ mac-wk2-stress

@philn philn self-assigned this Aug 20, 2022
@philn philn added Platform Portability improvements and other general platform improvements not driven directly by site bugs. WebKit Nightly Build labels Aug 20, 2022
@philn philn requested a review from aperezdc August 20, 2022 16:17
@philn philn added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 21, 2022
https://bugs.webkit.org/show_bug.cgi?id=244158

Reviewed by Adrian Perez de Castro.

This encoder claims to support the constrained-high profile whereas x264enc doesn't, so this encoder
will be used for some WebRTC layout tests requiring that profile.

* Tools/buildstream/elements/sdk/gst-plugins-bad.bst:
* Tools/buildstream/elements/sdk/libopenh264.bst:
* Tools/buildstream/patches/gst-plugins-bad-openh264-Register-debug-categories-earlier.patch: Added.
* Tools/buildstream/patches/gst-plugins-bad-openh264enc-Fix-constrained-high-encoding.patch: Added.

Canonical link: https://commits.webkit.org/253627@main
@webkit-commit-queue
Copy link
Collaborator

Committed 253627@main (265bd1b): https://commits.webkit.org/253627@main

Reviewed commits have been landed. Closing PR #3503 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 265bd1b into WebKit:main Aug 21, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 21, 2022
@philn philn deleted the eng/244158 branch August 21, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Portability improvements and other general platform improvements not driven directly by site bugs.
Projects
None yet
4 participants