Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pseudo-elements not treated as ASCII case-insensitive #3511

Merged
merged 0 commits into from Aug 21, 2022
Merged

Pseudo-elements not treated as ASCII case-insensitive #3511

merged 0 commits into from Aug 21, 2022

Conversation

rniwa
Copy link
Member

@rniwa rniwa commented Aug 21, 2022 •
edited by webkit-early-warning-system

2f1268f

Pseudo-elements not treated as ASCII case-insensitive
https://bugs.webkit.org/show_bug.cgi?id=202885

Reviewed by Antti Koivisto.

Match pseudo element case insensitively.

* LayoutTests/fast/css/before-after-pseudo-element-case-insensitivity-expected.html: Added.
* LayoutTests/fast/css/before-after-pseudo-element-case-insensitivity.html: Added.
* Source/WebCore/css/makeSelectorPseudoElementsMap.py:

Canonical link: https://commits.webkit.org/253631@main

d4937f3

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
❌ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@rniwa rniwa self-assigned this Aug 21, 2022
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 5129e79)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@rniwa rniwa added CSS Cascading Style Sheets implementation Safari Technology Preview labels Aug 21, 2022
@rniwa rniwa requested review from anttijk and smfr August 21, 2022 06:31
@anttijk
Copy link
Contributor

anttijk commented Aug 21, 2022

"Match pseudo element case insensibly."

insensitively, probably

@webkit-early-warning-system
Copy link
Collaborator

d4937f3

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
❌ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 21, 2022
@rniwa rniwa added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Aug 21, 2022
@webkit-early-warning-system webkit-early-warning-system merged commit 2f1268f into WebKit:main Aug 21, 2022
@webkit-commit-queue
Copy link
Collaborator

Committed 253631@main (2f1268f): https://commits.webkit.org/253631@main

Reviewed commits have been landed. Closing PR #3511 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 21, 2022
@rniwa rniwa deleted the fix202885 branch August 21, 2022 19:04
webkit-early-warning-system pushed a commit to kkinnunen-apple/WebKit that referenced this pull request Jan 25, 2023
@kkinnunen-apple
Update WebGL conformance test suite 2023-01-25
e233e41 
https://bugs.webkit.org/show_bug.cgi?id=251143
rdar://104641729

Reviewed by Antti Koivisto.

Update up to commit:
    Update clip / cull distance specs and tests (WebKit#3511)  c06fc8230ce4b1748be89ce3279cbe5348c9c9c9

* LayoutTests/webgl/1.0.x/conformance/uniforms/gl-get-uniform-non-current-program-expected.txt: Added.
* LayoutTests/webgl/1.0.x/conformance/uniforms/gl-get-uniform-non-current-program.html: Added.
* LayoutTests/webgl/2.0.y/conformance/uniforms/gl-get-uniform-non-current-program-expected.txt: Added.
* LayoutTests/webgl/2.0.y/conformance/uniforms/gl-get-uniform-non-current-program.html: Added.
* LayoutTests/webgl/2.0.y/conformance2/extensions/webgl-clip-cull-distance-expected.txt: Added.
* LayoutTests/webgl/2.0.y/conformance2/extensions/webgl-clip-cull-distance.html: Added.
* LayoutTests/webgl/2.0.y/conformance2/programs/get-uniform-indices-expected.txt: Added.
* LayoutTests/webgl/2.0.y/conformance2/programs/get-uniform-indices.html: Added.
* LayoutTests/webgl/resources/webgl_test_files/conformance/extensions/ext-sRGB.html:
* LayoutTests/webgl/resources/webgl_test_files/conformance/extensions/oes-texture-float.html:
* LayoutTests/webgl/resources/webgl_test_files/conformance/textures/misc/exif-orientation.html:
* LayoutTests/webgl/resources/webgl_test_files/conformance/uniforms/gl-get-uniform-non-current-program.html: Added.
* LayoutTests/webgl/resources/webgl_test_files/conformance2/extensions/webgl-clip-cull-distance.html: Added.
* LayoutTests/webgl/resources/webgl_test_files/conformance2/extensions/webgl-provoking-vertex.html:
* LayoutTests/webgl/resources/webgl_test_files/conformance2/programs/get-uniform-indices.html: Added.
* LayoutTests/webgl/resources/webgl_test_files/js/tests/compressed-texture-utils.js:
(let.testCompressedFormatsUnavailableWhenExtensionDisabled):
(let.CompressedTextureUtils):
* LayoutTests/webgl/resources/webgl_test_files/js/tests/ext-color-buffer-half-float.js:
(else.else.runUniqueObjectTest):
* LayoutTests/webgl/resources/webgl_test_files/resources/exif-orientation-originals/exif-orientation-test-6-90-cw.jpg: Renamed from LayoutTests/webgl/resources/webgl_test_files/resources/exif-orientation-originals/exif-orientation-test-8-90-cw.jpg.
* LayoutTests/webgl/resources/webgl_test_files/resources/exif-orientation-originals/exif-orientation-test-8-90-ccw.jpg: Renamed from LayoutTests/webgl/resources/webgl_test_files/resources/exif-orientation-originals/exif-orientation-test-6-90-ccw.jpg.
* LayoutTests/webgl/resources/webgl_test_files/resources/exif-orientation-test-6-90-cw.jpg: Renamed from LayoutTests/webgl/resources/webgl_test_files/resources/exif-orientation-test-6-90-ccw.jpg.
* LayoutTests/webgl/resources/webgl_test_files/resources/exif-orientation-test-8-90-ccw.jpg: Renamed from LayoutTests/webgl/resources/webgl_test_files/resources/exif-orientation-test-8-90-cw.jpg.

Canonical link: https://commits.webkit.org/259352@main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anttijk anttijk anttijk approved these changes

@smfr smfr Awaiting requested review from smfr

Assignees

@rniwa rniwa

Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Milestone
No milestone
5 participants
@rniwa @webkit-early-warning-system @anttijk @webkit-commit-queue @webkit-ews-buildbot