Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bounds-check in WebAssembly ref.call parser. #3555

Merged
merged 1 commit into from Aug 25, 2022
Merged

Add bounds-check in WebAssembly ref.call parser. #3555

merged 1 commit into from Aug 25, 2022

Conversation

ddegazio
Copy link
Contributor

@ddegazio ddegazio commented Aug 22, 2022 •
edited by webkit-early-warning-system

c827e06

Add bounds-check in WebAssembly ref.call parser.
https://bugs.webkit.org/show_bug.cgi?id=244223
rdar://98380955

Reviewed by Mark Lam.

* Source/JavaScriptCore/wasm/WasmFunctionParser.h:
(JSC::Wasm::FunctionParser<Context>::parseExpression):

Canonical link: https://commits.webkit.org/253757@main

a21100d

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc ✅ 🛠 tv ✅ 🧪 mac-wk1 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 mac-wk2 ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 jsc-mips-tests

@ddegazio ddegazio requested a review from a team as a code owner August 22, 2022 22:57
@webkit-early-warning-system
Copy link
Collaborator

a21100d

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc ✅ 🛠 tv ✅ 🧪 mac-wk1 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 mac-wk2 ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 jsc-mips-tests

MenloDorian
MenloDorian approved these changes Aug 22, 2022
View reviewed changes
Copy link

@MenloDorian MenloDorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@MenloDorian MenloDorian added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 25, 2022
@ddegazio
Add bounds-check in WebAssembly ref.call parser.
c827e06 
https://bugs.webkit.org/show_bug.cgi?id=244223
rdar://98380955

Reviewed by Mark Lam.

* Source/JavaScriptCore/wasm/WasmFunctionParser.h:
(JSC::Wasm::FunctionParser<Context>::parseExpression):

Canonical link: https://commits.webkit.org/253757@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Bounds-check-in-WebAssembly-ref-call-parser- branch from a21100d to c827e06 Compare August 25, 2022 00:39
@webkit-commit-queue
Copy link
Collaborator

Committed 253757@main (c827e06): https://commits.webkit.org/253757@main

Reviewed commits have been landed. Closing PR #3555 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit c827e06 into WebKit:main Aug 25, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 25, 2022
@ddegazio ddegazio deleted the eng/Bounds-check-in-WebAssembly-ref-call-parser- branch August 25, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MenloDorian MenloDorian MenloDorian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@ddegazio @webkit-early-warning-system @webkit-commit-queue @MenloDorian