[LBSE] Add support for 'foreignObject' elements #3664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikolaszimmermann
added
SVG
nikolaszimmermann
changed the title
|
This depends on PR #3532. |
|
EWS run on previous version of this PR (hash 4a35780)
|
nikolaszimmermann
force-pushed
the
eng/LBSE-Add-support-for-foreignObject-elements
branch
from
4a35780
to
406e515
Compare
|
PR #3532 was merged, this is ready to review now. |
|
EWS run on previous version of this PR (hash 406e515) |
webkit-ews-buildbot
added
the
merging-blocked
rwlbuis
requested changes
Aug 26, 2022
| @@ -114,8 +119,7 @@ bool SVGForeignObjectElement::rendererIsNeeded(const RenderStyle& style) | |||
| // parentOrShadowHostElement() instead. | |||
| RefPtr ancestor = parentElement(); | |||
| while (ancestor && ancestor->isSVGElement()) { | |||
| // FIXME: [LBSE] Upstream foreignObject support. | |||
| if (ancestor->renderer() && ancestor->renderer()->isLegacySVGHiddenContainer()) | |||
| if (ancestor->renderer() && (ancestor->renderer()->isSVGHiddenContainer() || ancestor->renderer()->isLegacySVGHiddenContainer())) | |||
There was a problem hiding this comment.
My as well introduce a isSVGHiddenContainerOrLegacySVGHiddenContainer method?
There was a problem hiding this comment.
Right, however it would only be this place using it -- I only introduced these helpers so far if there is more than one callsite that needs it.
Never mind, still learning github... |
nikolaszimmermann
removed
the
merging-blocked
nikolaszimmermann
force-pushed
the
eng/LBSE-Add-support-for-foreignObject-elements
branch
from
406e515
to
ab9dc4c
Compare
|
nikolaszimmermann
added
the
merge-queue
https://bugs.webkit.org/show_bug.cgi?id=243498 Reviewed by Rob Buis. Rename RenderSVGForeignObject -> LegacyRenderSVGForeignObject. Re-introduce RenderSVGForeignObject for LBSE. This marks the finish of the renderer conversion: all non-resource related renderers have both a legacy and LBSE Renderer class now: <foreignObject> was the last missing element in LBSE. Covered by existing svg/foreignObject tests, which all pass now in LBSE (except three that depends on clipping / masking / filters). * LayoutTests/platform/mac-monterey-wk2-lbse-text/TestExpectations: * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/foreignObject/background-render-phase-expected.txt: Added. * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/foreignObject/body-background-expected.txt: Added. * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/foreignObject/clip-expected.txt: Added. * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.txt: Added. * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/foreignObject/fO-display-none-expected.txt: Added. * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/foreignObject/fO-display-none-with-relative-pos-content-expected.txt: Added. * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/foreignObject/fO-parent-display-changes-expected.txt: Added. * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/foreignObject/fO-parent-display-none-expected.txt: Added. * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt: Added. * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt: Added. * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt: Added. * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/foreignObject/filter-expected.txt: Added. * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/foreignObject/mask-expected.txt: Added. * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/foreignObject/multiple-foreign-objects-expected.txt: Added. * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.png: Added. * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt: Added. * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/foreignObject/svg-document-as-direct-child-expected.txt: Added. * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/foreignObject/svg-document-in-html-document-expected.png: Added. * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/foreignObject/svg-document-in-html-document-expected.txt: Added. * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/foreignObject/text-tref-02-b-expected.png: Added. * LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/foreignObject/text-tref-02-b-expected.txt: Added. * LayoutTests/platform/mac/svg/foreignObject/fO-parent-display-changes-expected.txt: * LayoutTests/svg/foreignObject/fO-parent-display-changes.svg: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/accessibility/AccessibilitySVGElement.cpp: (WebCore::AccessibilitySVGElement::determineAccessibilityRole): * Source/WebCore/rendering/RenderElement.cpp: (WebCore::RenderElement::didAttachChild): (WebCore::RenderElement::layerCreationAllowedForSubtree const): * Source/WebCore/rendering/RenderElement.h: (WebCore::RenderElement::canContainFixedPositionObjects const): (WebCore::RenderElement::canContainAbsolutelyPositionedObjects const): * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateAncestorDependentState): (WebCore::RenderLayer::paintForegroundForFragments): * Source/WebCore/rendering/RenderLayerModelObject.cpp: (WebCore::RenderLayerModelObject::shouldPaintSVGRenderer const): * Source/WebCore/rendering/RenderLayerModelObject.h: * Source/WebCore/rendering/RenderObject.h: (WebCore::RenderObject::isLegacySVGForeignObject const): (WebCore::RenderObject::isSVGForeignObjectOrLegacySVGForeignObject const): * Source/WebCore/rendering/svg/LegacyRenderSVGForeignObject.cpp: Copied from Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp. (WebCore::LegacyRenderSVGForeignObject::LegacyRenderSVGForeignObject): (WebCore::LegacyRenderSVGForeignObject::foreignObjectElement const): (WebCore::LegacyRenderSVGForeignObject::paint): (WebCore::LegacyRenderSVGForeignObject::localToParentTransform const): (WebCore::LegacyRenderSVGForeignObject::updateLogicalWidth): (WebCore::LegacyRenderSVGForeignObject::computeLogicalHeight const): (WebCore::LegacyRenderSVGForeignObject::layout): (WebCore::LegacyRenderSVGForeignObject::nodeAtFloatPoint): * Source/WebCore/rendering/svg/LegacyRenderSVGForeignObject.h: Copied from Source/WebCore/rendering/svg/RenderSVGForeignObject.h. * Source/WebCore/rendering/svg/LegacyRenderSVGModelObject.h: * Source/WebCore/rendering/svg/RenderSVGBlock.cpp: (WebCore::RenderSVGBlock::updateFromStyle): (WebCore::RenderSVGBlock::mapLocalToContainer const): (WebCore::RenderSVGBlock::pushMappingToContainer const): * Source/WebCore/rendering/svg/RenderSVGBlock.h: * Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::paint): (WebCore::RenderSVGForeignObject::updateLogicalWidth): (WebCore::RenderSVGForeignObject::computeLogicalHeight const): (WebCore::RenderSVGForeignObject::layout): (WebCore::RenderSVGForeignObject::overflowClipRect const): (WebCore::RenderSVGForeignObject::updateFromStyle): (WebCore::RenderSVGForeignObject::applyTransform const): (WebCore::RenderSVGForeignObject::localToParentTransform const): Deleted. (WebCore::RenderSVGForeignObject::nodeAtFloatPoint): Deleted. * Source/WebCore/rendering/svg/RenderSVGForeignObject.h: * Source/WebCore/rendering/svg/RenderSVGModelObject.h: * Source/WebCore/rendering/svg/RenderSVGRoot.cpp: * Source/WebCore/rendering/svg/SVGContainerLayout.cpp: * Source/WebCore/svg/SVGElement.cpp: (WebCore::createSVGLayerAwareElementSet): * Source/WebCore/svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::createElementRenderer): (WebCore::SVGForeignObjectElement::rendererIsNeeded): Canonical link: https://commits.webkit.org/253816@main
webkit-early-warning-system
force-pushed
the
eng/LBSE-Add-support-for-foreignObject-elements
branch
from
ab9dc4c
to
5956331
Compare
|
Committed 253816@main (5956331): https://commits.webkit.org/253816@main Reviewed commits have been landed. Closing PR #3664 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
nikolaszimmermann
deleted the
eng/LBSE-Add-support-for-foreignObject-elements
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5956331
ab9dc4c
🛠 wpe🛠 mac-debug🛠 gtk🧪 ios-wk2🧪 gtk-wk2🧪 api-ios🧪 api-mac🧪 api-gtk🧪 mac-wk1🧪 mac-wk2🧪 mac-AS-debug-wk2🧪 mac-wk2-stress