New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REGRESSION (253685@main): [ Monterey wk2 ] fast/images/text-recognition/mac/cursor-types-for-recognized-text.html is a consistent failure #3680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on previous version of this PR (hash 7f8d50b) |
vitorroriz
force-pushed
the
eng/REGRESSION-253685main--Monterey-wk2--fastimagestext-recognitionmaccursor-types-for-recognized-text-html-is-a-consistent-failure
branch
from
August 25, 2022 23:31
7f8d50b
to
889ca70
Compare
vitorroriz
changed the title
REGRESSION (253685@main): [ Monterey wk2 ] fast/images/text-recognitiβ¦
REGRESSION (253685@main): [ Monterey wk2 ] fast/images/text-recognition/mac/cursor-types-for-recognized-text.html is a consistent failure
Aug 25, 2022
vitorroriz
added
New Bugs
Unclassified bugs are placed in this component until the correct component can be determined.
WebKit Nightly Build
labels
Aug 25, 2022
whsieh
approved these changes
Aug 25, 2022
β¦on/mac/cursor-types-for-recognized-text.html is a consistent failure https://bugs.webkit.org/show_bug.cgi?id=244272 <rdar://99051044> Reviewed by Wenson Hsieh. Test was failing because (253685@main) sets cursor:pointer for <a> with links, since this behavior can't be obtained from cursor:auto according to specification. Our live-text feature creates a overlay (a <div>) on the shadow DOM tree that depends on cursor:auto behavior to render a IBeam cursor while hovering the text on top of the image on the overlay. In this test, we had a <img> inside a <a>. After (253685@main) the div overlay was inheriting cursor:pointer from the <a> and therefore, we would not render a IBeam cursor for it. Solution: We are now styling the div#image-overlay in imageOverlay.css with cursor:auto. In that way, user can still style the wrapper image, and we preserve cursor:auto by default for div#image-overlay. * LayoutTests/fast/images/text-recognition/mac/cursor-types-for-recognized-text-expected.txt: * LayoutTests/fast/images/text-recognition/mac/cursor-types-for-recognized-text.html: testImage now tests the cursor hovering on the image area out of the text area. testOverlayDivFromImage tests the cursor hovering the overlay div on the text area. We have now 6 tests: 1. cursor on the image inside a link, out of text area, should be "Hand". 2. cursor on the image, with custom cursor, out of text area, should custom cursor. 3. cursor on the image, with user-select-none, inside a link, should be "Hand". 4. cursor on text area of overlay from image [1] should be "IBeam" (hinting selection). 5. cursor on text area of overlay from image [2] should be "IBeam" (hinting selection). 6. cursor on text area of overlay from image [3] should be Default (in our code called Pointer), since [3] has user-select-none. * Source/WebCore/html/shadow/imageOverlay.css: (div#image-overlay): Adding cursor:auto to div#image-overlay so we can hint text selection with IBeam cursor. Canonical link: https://commits.webkit.org/253823@main
webkit-early-warning-system
force-pushed
the
eng/REGRESSION-253685main--Monterey-wk2--fastimagestext-recognitionmaccursor-types-for-recognized-text-html-is-a-consistent-failure
branch
from
August 26, 2022 17:16
889ca70
to
543df0e
Compare
Committed 253823@main (543df0e): https://commits.webkit.org/253823@main Reviewed commits have been landed. Closing PR #3680 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
Aug 26, 2022
vitorroriz
deleted the
eng/REGRESSION-253685main--Monterey-wk2--fastimagestext-recognitionmaccursor-types-for-recognized-text-html-is-a-consistent-failure
branch
September 14, 2022 12:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
New Bugs
Unclassified bugs are placed in this component until the correct component can be determined.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
543df0e
889ca70
π wpe