SVGSMILElement should use WeakPtr & WeakHashMap instead of raw pointers #3700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webkit-ews-buildbot
added
the
merging-blocked
rniwa
added
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=244385 Reviewed by Chris Dumez. Replaced a raw pointer and a HashSet of raw pointers by WeakPtr and WeakHashMap. * Source/WebCore/svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::SVGSMILElement): (WebCore::SVGSMILElement::~SVGSMILElement): (WebCore::SVGSMILElement::reset): (WebCore::SVGSMILElement::setAttributeName): (WebCore::SVGSMILElement::setTargetElement): (WebCore::SVGSMILElement::progress): (WebCore::SVGSMILElement::notifyDependentsIntervalChanged): (WebCore::SVGSMILElement::addTimeDependent): (WebCore::SVGSMILElement::removeTimeDependent): * Source/WebCore/svg/animation/SVGSMILElement.h: (WebCore::SVGSMILElement::targetElement const): Canonical link: https://commits.webkit.org/253836@main
webkit-early-warning-system
force-pushed
the
fix244385
branch
from
397eb34
to
c9d4802
Compare
|
Committed 253836@main (c9d4802): https://commits.webkit.org/253836@main Reviewed commits have been landed. Closing PR #3700 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c9d4802
397eb34
🛠 mac-debug🛠 gtk🧪 gtk-wk2🧪 api-gtk