New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REGRESSION (iOS 16 Beta): The sound doesn't go by default through connected Airpods #3703
Conversation
EWS run on previous version of this PR (hash 719af25) |
719af25
to
a36caae
Compare
EWS run on previous version of this PR (hash a36caae) |
a36caae
to
bd22903
Compare
EWS run on previous version of this PR (hash bd22903) |
bd22903
to
c0bf9d6
Compare
EWS run on previous version of this PR (hash c0bf9d6) |
c0bf9d6
to
c0b2067
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me
β¦nected Airpods https://bugs.webkit.org/show_bug.cgi?id=241632 rdar://problem/96253856 Reviewed by Eric Carlson. We were previously computing the default microphone based on the current route. This is not always correlated with control center. Instead, we can rely on MediaExperience AVSystemController pickableRoutesForCategory to identify which route to select as a default. This ensures better synchronizatio with control center and does not change based on whether starting to capture on a non default audio route. For instance, on iPad, if the default pickable route is AirPods, but the web page decides to select the built in microphone, we will no longer consider the built in microphone as the default microphone. This will reduce the number of devicechange events as well. Manually tested. * Source/WTF/wtf/PlatformHave.h: * Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj: * Source/WebCore/PAL/pal/spi/ios/MediaExperienceAVSystemControllerSPI.h: * Source/WebCore/platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm: (WebCore::computeDefaultMicrophoneInformation): (WebCore::AVAudioSessionCaptureDeviceManager::retrieveAudioSessionCaptureDevices const): Canonical link: https://commits.webkit.org/253921@main
c0b2067
to
3f849c5
Compare
Committed 253921@main (3f849c5): https://commits.webkit.org/253921@main Reviewed commits have been landed. Closing PR #3703 and removing active labels. |
3f849c5
c0b2067