Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flatpak SDK] Partial revert of r249480 #371

Merged
merged 0 commits into from Apr 26, 2022
Merged

[Flatpak SDK] Partial revert of r249480 #371

merged 0 commits into from Apr 26, 2022

Conversation

philn
Copy link
Member

@philn philn commented Apr 24, 2022 •
edited by webkit-early-warning-system

b10e499

[Flatpak SDK] Partial revert of r249480
https://bugs.webkit.org/show_bug.cgi?id=239700

Patch by Philippe Normand <pnormand@igalia.com > on 2022-04-26
Reviewed by Adrian Perez de Castro.

The switch to upstream gtk3 recipe broke something related with icons handling and
introduced a crash in media/video-controls-drag.html. For the time being, revert to our
custom recipe.

This patch also updates the pipenv environment used to build the SDK, to BuildStream 1.6.5.

* Pipfile:
* Pipfile.lock:
* elements/qt5/qtbase.bst:
* elements/sdk-platform.bst:
* elements/sdk/adwaita-icon-theme.bst:
* elements/sdk/gst-plugins-base.bst:
* elements/sdk/gst-plugins-good.bst:
* elements/sdk/gtk+-3.bst: Added.

Canonical link: https://commits.webkit.org/249979@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@philn philn self-assigned this Apr 24, 2022
@philn philn requested a review from aperezdc April 24, 2022 08:18
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label Apr 24, 2022
@philn philn removed the merging-blocked Applied to prevent a change from being merged label Apr 25, 2022
@philn philn added the merge-queue Applied to send a pull request to merge-queue label Apr 26, 2022
@webkit-early-warning-system webkit-early-warning-system merged commit b10e499 into WebKit:main Apr 26, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r293419 (249979@main): https://commits.webkit.org/249979@main

Reviewed commits have been landed. Closing PR #371 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aperezdc aperezdc aperezdc approved these changes

Assignees

@philn philn

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@philn @webkit-early-warning-system @aperezdc