Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REGRESSION (253234@main): [ macOS wk1 Debug ] js/dom/modules/missing-exception-check-for-import.html is a consistent crash #3716

Merged
merged 1 commit into from Aug 26, 2022
Merged

REGRESSION (253234@main): [ macOS wk1 Debug ] js/dom/modules/missing-exception-check-for-import.html is a consistent crash #3716

merged 1 commit into from Aug 26, 2022

Conversation

karlrackler
Copy link
Contributor

@karlrackler karlrackler commented Aug 26, 2022 •
edited by Constellation

3912df6

REGRESSION (253234@main): [ macOS wk1 Debug ] js/dom/modules/missing-exception-check-for-import.html is a consistent crash
https://bugs.webkit.org/show_bug.cgi?id=244404
<rdar://99198236>

Reviewed by NOBODY (OOPS!).

Add missing exception checks.

* Source/WebCore/bindings/js/ScriptModuleLoader.cpp:
(WebCore::ScriptModuleLoader::importModule):

@karlrackler karlrackler self-assigned this Aug 26, 2022
@karlrackler karlrackler added New Bugs Unclassified bugs are placed in this component until the correct component can be determined. WebKit Nightly Build unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Aug 26, 2022
@karlrackler
[Gardening]: REGRESSION (253234@main): [ macOS wk1 Debug ] js/dom/mod…
aa9d68f 
…ules/missing-exception-check-for-import.html is a consistent crash

https://bugs.webkit.org/show_bug.cgi?id=244404
<rdar://99198236>

Unreviewed test gardening.

* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/253828@main
@webkit-early-warning-system
Copy link
Collaborator

4651a1b

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios   🛠 mac   🛠 wpe   🛠 🧪 win
  🛠 ios-sim   🛠 mac-debug   🛠 gtk   🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2   🛠 mac-AS-debug   🧪 gtk-wk2
  🧪 api-ios   🧪 api-mac   🧪 api-gtk
  🛠 tv   🧪 mac-wk1
  🛠 tv-sim   🧪 mac-wk2
  🛠 watch   🧪 mac-AS-debug-wk2
✅ 🛠 🧪 unsafe-merge   🛠 watch-sim   🧪 mac-wk2-stress

@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/REGRESSION-253234main--macOS-wk1-Debug--jsdommodulesmissing-exception-check-for-import-html-is-a-consistent-crash branch from 4651a1b to aa9d68f Compare August 26, 2022 19:36
@webkit-commit-queue
Copy link
Collaborator

Test gardening commit 253828@main (aa9d68f): https://commits.webkit.org/253828@main

Reviewed commits have been landed. Closing PR #3716 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit aa9d68f into WebKit:main Aug 26, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 26, 2022
@Constellation Constellation changed the title [Gardening]: REGRESSION (253234@main): [ macOS wk1 Debug ] js/dom/modules/missing-exception-check-for-import.html is a consistent crash REGRESSION (253234@main): [ macOS wk1 Debug ] js/dom/modules/missing-exception-check-for-import.html is a consistent crash Sep 10, 2022
@Constellation Constellation added JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. and removed New Bugs Unclassified bugs are placed in this component until the correct component can be determined. labels Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@karlrackler karlrackler

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
4 participants
@karlrackler @webkit-early-warning-system @webkit-commit-queue @Constellation