Omit document.referrer for third-party requests while in ephemeral mode #3789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliewolfe
added
WebCore Misc.
|
EWS run on previous version of this PR (hash da14e1c) |
darinadler
approved these changes
Oct 15, 2022
charliewolfe
force-pushed
the
eng/Omit-document-referrer-for-third-party-requests-while-in-ephemeral-mode
branch
from
da14e1c
to
2f6cd02
Compare
|
EWS run on current version of this PR (hash 2f6cd02)
|
https://bugs.webkit.org/show_bug.cgi?id=244518 <rdar://99578273> For third-party requests, omit document.referrer when accessed from JavaScript bindings while in ephemeral mode. Reviewed by Darin Adler. * LayoutTests/http/tests/resourceLoadStatistics/omit-document-referrer-nested-third-party-iframe-ephemeral-expected.txt: Added. * LayoutTests/http/tests/resourceLoadStatistics/omit-document-referrer-nested-third-party-iframe-ephemeral.html: Added. * LayoutTests/http/tests/resourceLoadStatistics/omit-document-referrer-third-party-iframe-ephemeral-expected.txt: Added. * LayoutTests/http/tests/resourceLoadStatistics/omit-document-referrer-third-party-iframe-ephemeral.html: Added. * LayoutTests/http/tests/resourceLoadStatistics/omit-referrer-for-navigation-ephemeral-expected.txt: Added. * LayoutTests/http/tests/resourceLoadStatistics/omit-referrer-for-navigation-ephemeral.html: Added. * Source/WebCore/dom/Document+HTML.idl: * Source/WebCore/dom/Document.cpp: (WebCore::Document::referrerForBindings): * Source/WebCore/dom/Document.h: Canonical link: https://commits.webkit.org/255649@main
webkit-early-warning-system
force-pushed
the
eng/Omit-document-referrer-for-third-party-requests-while-in-ephemeral-mode
branch
from
2f6cd02
to
09d247d
Compare
|
Committed 255649@main (09d247d): https://commits.webkit.org/255649@main Reviewed commits have been landed. Closing PR #3789 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
09d247d
2f6cd02
🛠 🧪 win🧪 ios-wk2🧪 api-ios🧪 api-mac🧪 api-gtk🧪 mac-wk1🧪 mac-wk2🧪 mac-AS-debug-wk2