New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several internationalization tests broken with ICU 69.1 #383
Several internationalization tests broken with ICU 69.1 #383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is an okay solution, but I'd rather call the function just shouldBeOneOf
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me too.
I agree. Will rename it. Sadly, this will make the commit messier, since this function already exists in some files. |
397a0ab
to
3099107
Compare
@mcatanzaro, force-pushing is going to stop |
Er... so what am I supposed to do? Unset and reset the label? |
BTW that was a mistake: I misused |
1a7cbe4
to
0eac6ea
Compare
Committed r293445 (250000@main): https://commits.webkit.org/250000@main Reviewed commits have been landed. Closing PR #383 and removing active labels. |
🎉 |
0eac6ea