Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Quirks] Disable resolution media feature on Expedia Group sites #3877

Merged
merged 1 commit into from Sep 8, 2022
Merged

[Quirks] Disable resolution media feature on Expedia Group sites #3877

merged 1 commit into from Sep 8, 2022

Conversation

gsnedders
Copy link
Contributor

@gsnedders gsnedders commented Aug 31, 2022 •
edited by webkit-early-warning-system

ee272e0

[Quirks] Disable resolution media feature on Expedia Group sites
https://bugs.webkit.org/show_bug.cgi?id=244627
rdar://98750324

Reviewed by Chris Dumez.

* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldDisableResolutionMediaQuery const):

Canonical link: https://commits.webkit.org/254256@main

99035b2

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@gsnedders gsnedders requested a review from cdumez as a code owner August 31, 2022 21:51
@gsnedders gsnedders self-assigned this Aug 31, 2022
@gsnedders gsnedders added CSS Cascading Style Sheets implementation WebKit Nightly Build labels Aug 31, 2022
@webkit-early-warning-system
Copy link
Collaborator

99035b2

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 1, 2022
cdumez
cdumez approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@cdumez cdumez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@gsnedders gsnedders added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Sep 7, 2022
@gsnedders
[Quirks] Disable resolution media feature on Expedia Group sites
ee272e0 
https://bugs.webkit.org/show_bug.cgi?id=244627
rdar://98750324

Reviewed by Chris Dumez.

* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldDisableResolutionMediaQuery const):

Canonical link: https://commits.webkit.org/254256@main
@webkit-early-warning-system webkit-early-warning-system merged commit ee272e0 into WebKit:main Sep 8, 2022
@webkit-commit-queue
Copy link
Collaborator

Committed 254256@main (ee272e0): https://commits.webkit.org/254256@main

Reviewed commits have been landed. Closing PR #3877 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 8, 2022
@gsnedders gsnedders deleted the expedia-no-resolution branch August 1, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez cdumez approved these changes

Assignees

@gsnedders gsnedders

Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Milestone
No milestone
5 participants
@gsnedders @webkit-early-warning-system @webkit-commit-queue @cdumez @webkit-ews-buildbot